new calendar endpoints | part 2/4 | endpoint base#928
Merged
mauteri merged 35 commits intoGatherPress:developfrom Oct 22, 2024
Merged
Conversation
…oint_Template::template_include() expects string, false given.
…dpoints\Endpoint.
Contributor
Preview changes with PlaygroundYou can preview the recent changes for PR#928 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
4 tasks
8 tasks
mauteri
approved these changes
Oct 22, 2024
carstingaxion
added a commit
to carstingaxion/gatherpress
that referenced
this pull request
Oct 25, 2024
carstingaxion
added a commit
to carstingaxion/gatherpress
that referenced
this pull request
Oct 25, 2024
carstingaxion
added a commit
to carstingaxion/gatherpress
that referenced
this pull request
Jul 23, 2025
(... to avoid the never ending rebase merge conflicts, that apperaed when I tried to update the aged PR#955 to "develop" after months of commits happened.) Included were 18 commits: --- commit 3d2dfe6 Author: Carsten Bach <mail@carsten-bach.de> Date: Fri Oct 25 02:11:52 2024 +0200 Fix: MD049/emphasis-style Emphasis style should be consistent commit 65f00a9 Author: Carsten Bach <mail@carsten-bach.de> Date: Fri Oct 25 02:07:32 2024 +0200 Ignore phpstan error (probably introduced with GatherPress#928) commit 48244f6 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 10:24:29 2024 +0200 Fix: Parameter #1 $string of function str_pad expects string, int given commit b70ef88 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 10:21:56 2024 +0200 Fix: Access to undefined constant GatherPress\Core\Calendars::DATETIME_FORMAT. commit a0dfc36 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 10:20:03 2024 +0200 Fix: PHPDoc tag @throws with type GatherPress\Core\Exception is not subtype of Throwable commit acd837b Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 10:18:55 2024 +0200 Fix: Offset 'type' on array{url: string|false, attr: string} in isset() does not exist. commit 6ddf147 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 10:14:51 2024 +0200 Fix: Parameter #1 $object_type of function get_object_taxonomies expects array<string>|string|WP_Post, int given. commit 0ffbcba Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 10:11:42 2024 +0200 BUGFIX: Remove superflous file commit b028af0 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 10:03:47 2024 +0200 Fix: Function is_archive invoked with 1 parameter, 0 required. commit 8f33582 Merge: 34ad38e 6478e00 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 01:47:58 2024 +0200 Merge branch 'develop' into feature/fragment-of-pr-831-endpoint-implementations commit 34ad38e Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 01:42:12 2024 +0200 Fix for CS commit 13aaf22 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 01:39:56 2024 +0200 NEW '.../topic/123/ical' endpoint commit 878159f Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 01:39:25 2024 +0200 NEW '.../venue/abc/ical' endpoint commit 6633ec5 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 01:38:57 2024 +0200 NEW '.../event/xyz/ical' endpoint commit 883a819 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 01:38:20 2024 +0200 NEW '.../event/ical' endpoint commit 29a39b1 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 01:26:49 2024 +0200 Add overrideable-templates , like described in GatherPress#929 commit 3eb3d6c Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 01:18:25 2024 +0200 Add 'Add-to-calendar' to feature list commit fe58c49 Author: Carsten Bach <mail@carsten-bach.de> Date: Tue Oct 22 00:13:39 2024 +0200 New class responsible for managing calendar-related endpoints in GatherPress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the fragmentation of #831, which was way too big to review or merge.
I try to do better in the future.
Description of the Change
This PR adds the basic class to handle the custom endpoints. The
Endpointclass provides functionality for registering custom endpoints based on post types or taxonomies. It defines rewrite rules, adds custom query variables, and handles wether to redirect or to load a custom template.Closes #How to test the Change
Changelog Entry
Credits
Props @carstingaxion
Checklist: