Skip to content

GP-1131: Fix RSVP view to only include RSVPs; Fix counts; Fix 'Mine' query.#1133

Merged
mauteri merged 5 commits intodevelopfrom
GP-1131
Jul 27, 2025
Merged

GP-1131: Fix RSVP view to only include RSVPs; Fix counts; Fix 'Mine' query.#1133
mauteri merged 5 commits intodevelopfrom
GP-1131

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Jul 26, 2025 •
edited
Loading

Bug with missing filter for remove/add for RSVP exclusion in comment query. Fixed issues with counts. Fixed issue with "Mine" filter.

Description of the Change

Closes #1131

How to test the Change

Changelog Entry

Fixed - Bug fix

Credits

Props @mauteri, @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Jul 26, 2025

PR Summary

  • Refined RSVP Search Feature
    The get_rsvps method now includes a user_id parameter. This will give users the ability to filter RSVPs based on their personal profile, enhancing their search experience.

  • Improved Handling of Exclusion Filters
    The code has been updated to temporarily disable any exclusion filters for RSVP comments while a user's request is being processed. Once the request is complete, the filter is reinstated. This ensures comments relevant to the user's search are not inadvertently dismissed.

  • Streamlined RSVP Comment Count
    The get_rsvp_count method now accepts user_id in its arguments. This helps fetch the accurate RSVP comment count for each user, improving the function's precision.

  • Optimized Views Handling
    The get_views method has been updated. Redundant code has been eliminated, while ensuring the exclusion filter handling logic remains intact. This change makes the system more efficient without sacrificing any of the original functionality.

@mauteri mauteri requested a review from carstingaxion July 26, 2025 17:31
@mauteri mauteri marked this pull request as ready for review July 26, 2025 18:47
@mauteri mauteri mentioned this pull request Jul 26, 2025
Closed
1 task
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 27, 2025

Preview changes with Playground

You can preview the recent changes for PR#1133 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri merged commit f44b6bb into develop Jul 27, 2025
15 checks passed
@mauteri mauteri deleted the GP-1131 branch July 27, 2025 13:06
@carstingaxion
Copy link
Copy Markdown
Collaborator

carstingaxion commented Jul 27, 2025

Ok, nice you were able to fix this @mauteri.
I would have liked to do the requested review, but this was too fast to respond.

@mauteri
Copy link
Copy Markdown
Contributor Author

mauteri commented Jul 27, 2025

You can still review. I can do follow up fixes if you find issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carstingaxion carstingaxion Awaiting requested review from carstingaxion

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Commenting on an event is saved as RSVP without status

2 participants

@mauteri @carstingaxion