Skip to content

Version 0.32.1#1060

Merged
mauteri merged 21 commits intomainfrom
version-0.32.1
Apr 23, 2025
Merged

Version 0.32.1#1060
mauteri merged 21 commits intomainfrom
version-0.32.1

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Apr 21, 2025

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Apr 21, 2025

PR Summary

  • Dependency Update: The team has updated a component our system relies on (pmc/unit-test) to gain improvements from a newer version (dev-fix-mock-mailer).
  • Version Increment: The version number of our plugin has been raised from 0.32.0 to 0.32.1, signaling minor updates and tweaks.
  • Added Author Support: Our program can now handle 'author' information in specific areas (class-event-setup.php and class-venue.php), meaning you can see who created what.
  • Adjusted Method Accessibility: The set_main_sub_page function was once accessible only within the class it resides in but has been made universally accessible (public) from class-settings.php. This adjustment allows for more functionality.
  • Plan for Sanitization: The team has added a note in class-settings.php for future upgrade of our code to clean inputs in the register_settings area. This will help to further secure the system.
  • README Update: The user document (README) has been updated to reflect the new plugin version (0.32.1) and improved compatibility up to version 6.8.
  • Dependency Streamlining: We improved code efficiency by removing an unnecessary load command.
  • Testing Improvements: Added a new test case in class-test-settings.php ensuring the functionality of set_main_sub_page when the 'init' action is triggered, helping us maintain reliability and stability in future deployments.

@mauteri mauteri marked this pull request as ready for review April 21, 2025 13:07
composer.json Outdated
],
"require": {
"pmc/unit-test": "dev-main",
"pmc/unit-test": "dev-fix-mock-mailer",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauteri Is this intentional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was, but was fixed upstream so has been reverted to dev-main

@github-actions
Copy link
Copy Markdown
Contributor

Preview changes with Playground

You can preview the recent changes for PR#1060 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

Copy link
Copy Markdown
Collaborator

@stephenerdelyi stephenerdelyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jmarx jmarx self-requested a review April 21, 2025 23:40
@jmarx
Copy link
Copy Markdown
Collaborator

jmarx commented Apr 21, 2025

LGTM!

@mauteri mauteri merged commit 56aed98 into main Apr 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants