Skip to content

Jeff changes 0.32.1#1059

Merged
mauteri merged 6 commits intoversion-0.32.1from
jeff-changes-0.32.1
Apr 21, 2025
Merged

Jeff changes 0.32.1#1059
mauteri merged 6 commits intoversion-0.32.1from
jeff-changes-0.32.1

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Apr 21, 2025

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mauteri mauteri marked this pull request as ready for review April 21, 2025 13:01
@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Apr 21, 2025

PR Summary

  • Adjustment in Class Settings
    The constructor in class-settings.php has been simplified by removing the call to set_main_sub_page() function.

  • Setup Hooks modifications
    An init action hook has been added within setup_hooks() in class-settings.php which will aid in initiating a call to the set_main_sub_page method.

  • Change in Visibility of Method
    The visibility of the set_main_sub_page method in class-settings.php has been adjusted from protected to public, enhancing its accessibility.

  • Updates in Tests
    The testing module found in class-test-settings.php has been updated to validate the new action for the init hook that specifically calls set_main_sub_page.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 21, 2025

Preview changes with Playground

You can preview the recent changes for PR#1059 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri merged commit cb0665b into version-0.32.1 Apr 21, 2025
27 checks passed
@mauteri mauteri deleted the jeff-changes-0.32.1 branch April 21, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mauteri @jmarx