Skip to content

Bug in dropdown in the RSVP Reponse block#1034

Merged
mauteri merged 3 commits intodevelopfrom
GP-1033
Mar 16, 2025
Merged

Bug in dropdown in the RSVP Reponse block#1034
mauteri merged 3 commits intodevelopfrom
GP-1033

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Mar 16, 2025 •
edited
Loading

Description of the Change

  • Fixes dropdown in RSVP Response block which remained disabled when it should be enabled.
  • Fixes focus trap issue with events not being removed properly.

Closes #1033

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @mauteri

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Mar 16, 2025

PR Summary

  • Version Update in view.asset.php
    The version has been updated in view.asset.php to '02dd663fb363aac4de85', ensuring that we are using the latest, most secure, and efficient version.

  • Optimizing RSVP Handling in view.js
    We have streamlined the checks for variable visibility in the RSVP handling in view.js. This leads to a more efficient process, aside from making the code cleaner and easier to maintain.

  • Dropdown Disabling Logic Added
    We have also introduced a new feature that will automatically disable the dropdown when "Attending" is the only visible option and is currently selected. This is designed to improve user experience by making the interface more intuitive and avoids unnecessary clicks for the users.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 16, 2025

Preview changes with Playground

You can preview the recent changes for PR#1034 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri marked this pull request as ready for review March 16, 2025 21:50
@mauteri mauteri merged commit a946d0b into develop Mar 16, 2025
9 checks passed
@mauteri mauteri deleted the GP-1033 branch March 16, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmarx jmarx jmarx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in dropdown in the RSVP Reponse block

2 participants

@mauteri @jmarx