chore(core): organize deps using workspace.dependencies by borngraced · Pull Request #2449 · GLEECBTC/komodo-defi-framework

borngraced · 2025-05-08T12:31:09Z

This enables us to organize multiple packages under a single workspace, share dependencies, etc

Compile time improvements

• Before: cargo build --timings shows 2.20 s
• After: end-to-end workspace build is 1.24-58 s (≈ 28 – 44 % faster overall)

dimxy · 2025-05-13T16:34:49Z

I like this PR very much, thank you.

Currently I am having one cargo build error (after cargo clean):

error[E0425]: cannot find value `OsRng` in crate `bip39::rand_core`
  --> mm2src/crypto/src/mnemonic.rs:47:37
   |
47 |     let mut rng = bip39::rand_core::OsRng;
   |                                     ^^^^^ not found in `bip39::rand_core`

borngraced · 2025-05-13T21:23:40Z

I like this PR very much, thank you.

Currently I am having one cargo build error (after cargo clean):

error[E0425]: cannot find value `OsRng` in crate `bip39::rand_core`
  --> mm2src/crypto/src/mnemonic.rs:47:37
   |
47 |     let mut rng = bip39::rand_core::OsRng;
   |                                     ^^^^^ not found in `bip39::rand_core`

thanks, I needed to update rand_core for bip39 crate

shamardy · 2025-05-13T23:25:30Z

Cargo.lock

 dependencies = [
 "bitcoin_hashes",
- "rand_core 0.6.4",
+ "rand_core 0.5.1",


thanks, I needed to update rand_core for bip39 crate

It actually downgrades it, can you please explain why?

I didn’t explicitly request a downgrade. It happened because Cargo resolves dependencies based on the semver-compatible version range specified (e.g., v1...v5), and it selects the highest compatible version available by default. But if another dependency restricts it to a lower version, Cargo might resolve to that instead.

I believe this change doesn't break, change anything we can leave it until we no longer rely on rand_core 0.5.1 or we upgrade bip39 crate

I believe this change doesn't break, change anything we can leave it until we no longer rely on rand_core 0.5.1 or we upgrade bip39 crate

We can also revert this to rand_core 0.6.4 as I think it won't cause problems, will it? cargo.lock will be relying less on rand_core 0.5.1 which makes it easier to remove it in the future. These left artifacts can persist over time as cargo might never resolve it on it's own if the dependency tree is complex.

shamardy · 2025-05-13T23:28:44Z

Cargo.lock

 "sha2 0.10.7",
 "smallvec 1.6.1",
- "syn 2.0.38",
+ "syn 1.0.95",


Also reason for this downgrade

same reason as my first paragraph above

#2449 (comment) As a general rule, always try to use the latest version if it's in the deps tree and if possible.

Cargo.lock

shamardy

This was much needed, thanks a lot! All above comments and the below one are non-blockers!

Cargo.toml

mariocynicys · 2025-05-19T08:29:54Z

Cargo.toml

+# using webpki-tokio to avoid rejecting valid certificates
+# got "invalid certificate: UnknownIssuer" for https://ropsten.infura.io on iOS using default-features


this doesn't fit here as the feature webpki-tokio is mentioned in children .tomls

shamardy · 2025-05-20T08:20:23Z

@mariocynicys @dimxy do you have any more review comments or iterations to go here?

mariocynicys · 2025-05-20T08:26:50Z

@shamardy i didn't attempt reviewing this anyway so i shouldn't be a blocker. that said, when i took a look i felt the only efficient way to review this is with a script 😂 - it checks that every workspace dep has the highest version out of the versions that showed up in the crates that used it.

can try this on the weekend or something, but since this PR is benign, we don't have to wait for that and can merge it right away i guess.

shamardy · 2025-05-20T08:35:59Z

when i took a look i felt the only efficient way to review this is with a script

Checking cargo.lock was enough for me

shamardy · 2025-05-21T21:59:25Z

@borngraced why was this commit needed 01367f9 where it reverted some deps? I thought the deps were fine and I approved them before this commit.

borngraced · 2025-05-22T02:33:21Z

@borngraced why was this commit needed 01367f9 where it reverted some deps? I thought the deps were fine and I approved them before this commit.

I initially didn't intend to update those deps but somehow got updated due to a package I updated so I was able to revert it...

shamardy · 2025-05-22T02:48:31Z

I initially didn't intend to update those deps but somehow got updated due to a package I updated so I was able to revert it...

I thought the update wasn't bad. Some deps were removed from cargo.lock after the update, but some were added too. Can you please check which version you think is better before I do another review.

borngraced · 2025-05-22T10:15:38Z

I initially didn't intend to update those deps but somehow got updated due to a package I updated so I was able to revert it...

I thought the update wasn't bad. Some deps were removed from cargo.lock after the update, but some were added too. Can you please check which version you think is better before I do another review.

This shouldn't be an issue or a blocker for now. These deps will be updated in toolchain upgrade PR(updated some already)

The dep i updated was signature and ed25519-dalek btw

shamardy · 2025-05-23T01:38:00Z

This shouldn't be an issue or a blocker for now. These deps will be updated in toolchain upgrade PR(updated some already)

The dep i updated was signature and ed25519-dalek btw

Had to check cargo.lock again and it's actually better now. Thanks

* dev: fix(evm-api): find enabled erc20 token using platform ticker (#2445) chore(docs): add DeepWiki badge to README (#2463) chore(core): organize deps using workspace.dependencies (#2449) feat(db-arch): more dbdir to address_dir replacements (#2398)

* dev: (29 commits) fix(p2pk): validate expected pubkey correctly for p2pk inputs (#2408) chore(docs): update old urls referencing atomicdex or old docs pages (#2428) improvement(p2p): remove hardcoded seeds (#2439) fix(evm-api): find enabled erc20 token using platform ticker (#2445) chore(docs): add DeepWiki badge to README (#2463) chore(core): organize deps using workspace.dependencies (#2449) feat(db-arch): more dbdir to address_dir replacements (#2398) chore(build-artifacts): remove duplicated mm2 build artifacts (#2448) feat(pubkey-banning): expirable bans (#2455) fix(eth-balance-events): serialize eth address using AddrToString (#2440) chore(deps): remove base58 and replace it completely with bs58 (#2427) feat(tron): initial groundwork for full TRON integration (#2425) fix(UTXO): improve tx fee calculation and min relay fee handling (#2316) deps(timed-map): bump to 1.3.1 (#2413) improvement(tendermint): safer IBC channel handler (#2298) chore(release): complete v2.4.0-beta changelogs (#2436) fix(event-streaming): initial addresses registration in utxo balance streaming (#2431) improvement(watchers): re-write use-watchers handling (#2430) fix(evm): make withdraw_nft work in HD mode (#2424) feat(taproot): support parsing taproot output address types ...

* lr-swap-wip: (37 commits) fix custom token error name fix getting chain_id from protocol_data refactor (review): use dedicated large error cfg, add new fn to FromApiValueError, fix TODO, use experimental namespace for lr rpc, more Ticker alias feat(walletconnect): add WalletConnect v2 support for EVM and Cosmos (GLEECBTC#2223) feat(ibc-routing-part-1): supporting entire Cosmos network for swaps (GLEECBTC#2459) fix(test): fix HD Wallet message signing tests (GLEECBTC#2474) improvement(builds): enable static CRT linking for MSVC builds (GLEECBTC#2464) feat(wallet): implement HD multi-address support for message signing (GLEECBTC#2432) fix(p2pk): validate expected pubkey correctly for p2pk inputs (GLEECBTC#2408) chore(docs): update old urls referencing atomicdex or old docs pages (GLEECBTC#2428) improvement(p2p): remove hardcoded seeds (GLEECBTC#2439) fix(evm-api): find enabled erc20 token using platform ticker (GLEECBTC#2445) chore(docs): add DeepWiki badge to README (GLEECBTC#2463) chore(core): organize deps using workspace.dependencies (GLEECBTC#2449) feat(db-arch): more dbdir to address_dir replacements (GLEECBTC#2398) chore(build-artifacts): remove duplicated mm2 build artifacts (GLEECBTC#2448) feat(pubkey-banning): expirable bans (GLEECBTC#2455) fix(eth-balance-events): serialize eth address using AddrToString (GLEECBTC#2440) chore(deps): remove base58 and replace it completely with bs58 (GLEECBTC#2427) feat(tron): initial groundwork for full TRON integration (GLEECBTC#2425) ...

borngraced added 6 commits April 28, 2025 05:09

save dev state

e1e9fdb

save Cargo.toml

afbb4d1

save state

8a56816

save state

13d3eb3

save dev state

bd3f605

more changes

28df78c

borngraced self-assigned this May 8, 2025

borngraced added the status: in progress label May 8, 2025

borngraced added 7 commits May 8, 2025 13:56

revert netlinnk-proto dep

b174b2b

move more deps

e801209

move remaining deps

f225594

move more deps

1a415fb

revert updated deps

54d3431

revert more updated deps

63b5cb3

revert more deps

5d4fbb7

borngraced added status: pending review and removed status: in progress labels May 11, 2025

Merge branch 'dev' into workspace-crates

3106c8c

shamardy added the priority: high Important tasks that need attention soon. label May 12, 2025

revert unnecessary deps upgrade

7026e75

fix compilation error

63cdc4c

borngraced added 3 commits May 13, 2025 22:35

merge with dev and fix conflicts

b6b88d3

remove tonic default features

58bd3c6

nits

53464cb

shamardy reviewed May 13, 2025

View reviewed changes

Cargo.lock Outdated Show resolved Hide resolved

shamardy previously approved these changes May 13, 2025

View reviewed changes

Cargo.toml Show resolved Hide resolved

return resolver doc url comment

ae66c53

borngraced dismissed shamardy’s stale review via ae66c53 May 14, 2025 05:51

borngraced added 2 commits May 15, 2025 05:35

revert some deps

01367f9

remove unused dep

1b56dfd

mariocynicys reviewed May 19, 2025

View reviewed changes

remove unintended comment on hyper-rustls

e1d3595

borngraced added 2 commits May 20, 2025 13:04

Merge branch 'dev' into workspace-crates

c90eff8

Merge branch 'dev' into workspace-crates

72f96b3

shamardy approved these changes May 23, 2025

View reviewed changes

shamardy merged commit e42a9af into dev May 23, 2025
20 of 24 checks passed

shamardy deleted the workspace-crates branch May 23, 2025 01:39

dimxy mentioned this pull request May 27, 2025

feat(tests): zcoin unit test to validate dex fee #2460

Merged

shamardy mentioned this pull request Jun 16, 2025

chore(release): v2.5.0-beta #2491

Merged

		# using webpki-tokio to avoid rejecting valid certificates
		# got "invalid certificate: UnknownIssuer" for https://ropsten.infura.io on iOS using default-features

Conversation

borngraced commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Compile time improvements

Uh oh!

dimxy commented May 13, 2025

Uh oh!

borngraced commented May 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shamardy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shamardy commented May 20, 2025

Uh oh!

mariocynicys commented May 20, 2025

Uh oh!

shamardy commented May 20, 2025

Uh oh!

shamardy commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

borngraced commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shamardy commented May 22, 2025

Uh oh!

borngraced commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shamardy commented May 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

borngraced commented May 8, 2025 •

edited

Loading

shamardy commented May 21, 2025 •

edited

Loading

borngraced commented May 22, 2025 •

edited

Loading

borngraced commented May 22, 2025 •

edited

Loading