feat(solana-swap): solana swap protocol v1 POC#2091
Merged
Conversation
shamardy
reviewed
Mar 29, 2024
Collaborator
shamardy
left a comment
There was a problem hiding this comment.
Thank you for the PR! This is the first review iteration concerned with cleaning up the code a bit so I can easily review it.
Collaborator
|
@mj-blockydevs first step is to merge with latest dev to resolve conflicts |
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
|
Recent updates:
|
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
shamardy
reviewed
Jun 13, 2024
Collaborator
shamardy
left a comment
There was a problem hiding this comment.
Thank you for the fixes! Next review iteration!
…ion async instead of fut, better error handling, log used in tests instead of print, redundant test removed Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
|
Here are the recent adjustments based on your PR reviews:
Feel free to let me know if there is anything else we should adjust before merging this stage of the work. To use a different source of constants, I need them to be accepted in this PR. |
borngraced
suggested changes
Jun 15, 2024
borngraced
left a comment
There was a problem hiding this comment.
Great work!. only one comment after taking a quick look.
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
shamardy
reviewed
Jun 19, 2024
Collaborator
shamardy
left a comment
There was a problem hiding this comment.
Last comment from my side! Once all previous unresolved comments are fixed alongside the below one I approve this PR.
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
…recently deployed one Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas+instead@blockydevs.com>
dimxy
pushed a commit
that referenced
this pull request
Jul 3, 2024
* dev: fix(restrictions): remove wallet-only restriction from max_maker_vol (#2153) feat(tendermint): support unsigned txs for ledger's keplr extension (#2148) chore(toolchain): upgrade to 1.72 nightly (#2149) feat(solana-swap): solana swap protocol v1 POC (#2091) fix(docs): update cargo test command (#2144)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the following SwapOps trait methods for SolanaCoin in the defi framework:
Test cases for: