fix(zcoin): syncing and activation improvements#2089
Merged
Conversation
shamardy
reviewed
Apr 6, 2024
Collaborator
shamardy
left a comment
There was a problem hiding this comment.
Thank you for the PR! only one comment!
BTW, the GUI currently has to poll the task status API every few seconds to get the sync status, in the future we will use streaming events for this instead and we wouldn't need to stop sending sync status in the streaming events, we will probably send an event to indicate that initial sync is done but keep sending new blocks, transactions etc..
shamardy
approved these changes
Apr 9, 2024
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Apr 9, 2024
* dev: feat(nft-swap): nft swap protocol v2 POC (GLEECBTC#2084) fix(zcoin): syncing and activation improvements (GLEECBTC#2089) feat(crypto): mnemonic generation/encryption/decryption/storage (GLEECBTC#2014) fix(eth): error handling in RPCs (GLEECBTC#2090)
This was referenced Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first_sync_blockfromSyncStatusand stop sendingfirst_sync_blockwhile activation is in progressfirst_sync_blockin Activation Result only after activation is completedcloses: #2022