Conversation
The KIP0003 consensus rule was added in the `dev` branch as "logging only", i.e. as disabled. However, in the `patch-s8-prepare-hf-test` branch, which we used for testing on hfnet, it's already enabled (as seen in [this commit](783fc1f)). For the release, we should enable this rule and make the logging optional using the hfnet category.
DeckerSU
added a commit
to DeckerSU/KomodoOcean
that referenced
this pull request
Aug 20, 2024
The KIP0003 consensus rule was added in the `dev` branch as "logging only", i.e. as disabled. However, in the `patch-s8-prepare-hf-test` branch, which we used for testing on hfnet, it's already enabled (as seen in [this commit](GLEECBTC/komodo-daemon@783fc1f)). For the release, we should enable this rule and make the logging optional using the hfnet category. - GLEECBTC/komodo-daemon#626
ca333
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KIP0003 consensus rule was added in the
devbranch as "logging only", i.e. as disabled. However, in thepatch-s8-prepare-hf-testbranch, which we used for testing on hfnet, it's already enabled(as seen in this commit). For the release, we should enable this rule and make the logging optional using the hfnet category.