Skip to content

allow -ac_private for the ZOMBIE test chain#615

Merged
ca333 merged 1 commit intodevfrom
patch-add-zombie-warning
Jun 11, 2024
Merged

allow -ac_private for the ZOMBIE test chain#615
ca333 merged 1 commit intodevfrom
patch-add-zombie-warning

Conversation

@DeckerSU
Copy link
Copy Markdown

@DeckerSU DeckerSU commented Mar 7, 2024

Better solution for the issues mentioned in #589 .

Better solution for the issues mentioned in
#589 .
DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Mar 7, 2024
@TheComputerGenie
Copy link
Copy Markdown

Wouldn't the "better solution" be to drop the concept? We don't seem to support the opposite concept (coding "if you want public only, you cannot have it because there's no reason to just not use KMD").

@DeckerSU
Copy link
Copy Markdown
Author

DeckerSU commented Mar 8, 2024

Wouldn't the "better solution" be to drop the concept? We don't seem to support the opposite concept (coding "if you want public only, you cannot have it because there's no reason to just not use KMD").

If you would like to discuss the "concept" itself, please create a separate issue. Your comment is not related to this pull request, which is solely intended to add permission for the ZOMBIE chain to use -ac_private. If you believe this permission should be extended to other chains as well, please explain why in a separate issue. Thank you!

@smk762 smk762 requested review from Alrighttt, ca333, cipig, dimxy and smk762 March 8, 2024 04:24
Copy link
Copy Markdown

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Confirmed no issues with launch for KMD, PIRATE or ZOMBIE, and shutdown when attempting launch of private chain with tickers not in the allow list.

@TheComputerGenie
Copy link
Copy Markdown

Wouldn't the "better solution" be to drop the concept? We don't seem to support the opposite concept (coding "if you want public only, you cannot have it because there's no reason to just not use KMD").

If you would like to discuss the "concept" itself, please create a separate issue. Your comment is not related to this pull request, which is solely intended to add permission for the ZOMBIE chain to use -ac_private. If you believe this permission should be extended to other chains as well, please explain why in a separate issue. Thank you!

Yes, I'll get right on creating a separate issue which addresses this pull request which addresses an issue that isn't this pull request so that that not-new issue (which addresses this pull request which addresses an issue that isn't this pull request) can sit ignored for years and then quietly closed; that's a much better solution than discussing the merits of this pull request inside the conversation mechanism of this pull request.

Copy link
Copy Markdown
Collaborator

@dimxy dimxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I was able to run ZOMBIE node with this fix,
this also fixes an issue when ac_name was an unsupported private chain we got a misleading 'error in HDD data' msg

@ca333 ca333 merged commit faa9996 into dev Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants