Skip to content

update rust to 1.69.0#595

Merged
DeckerSU merged 5 commits intoGLEECBTC:devfrom
DeckerSU:patch-bump-rust
Oct 28, 2023
Merged

update rust to 1.69.0#595
DeckerSU merged 5 commits intoGLEECBTC:devfrom
DeckerSU:patch-bump-rust

Conversation

@DeckerSU
Copy link
Copy Markdown

This pull request updates Rust to version 1.69.0. However, we still need to rework the Rust integration, build the crates, and address other related issues. Additionally, this update is expected to resolve the known "not mach-o or llvm bitcode file" issue on MacOS native builds, as described here: #594 (comment). Please refrain from merging this pull request until all tests, including a sync from scratch and sapling crypto, have been completed.

Furthermore, we have the opportunity to address the warnings that arise during the build of Rust crates.

the cross-compilation process in the rust komodo recipe
differs slightly from the current native_rust recipe used
in Zcash. therefore, we have commented out all invocations
of the "update_stdlib_hash" function until the komodo rust
recipe is updated.
todo: we still need rework rust integration, crates build, etc.
@Alrighttt
Copy link
Copy Markdown

Just wanted to share I have been using 1.66 on my mac for a few weeks without any issue. Will do further testing with 1.69.0.

I am curious why you choose 1.69.0.

@DeckerSU
Copy link
Copy Markdown
Author

DeckerSU commented Oct 26, 2023

I am curious why you choose 1.69.0.

I chose version 1.69 because it is the current version used by ZCash. Additionally, for macOS cross-compilation, KomodoOcean will be using Clang 15.0.6, and it is preferable that the Clang compiler matches the LLVM version of the Rust compiler. Rust version 1.69 is using LLVM 15.0.7, which can be verified by running rustc --version -v.

By the way, the issue with Komodo MacOS CI / MacOS Build has been resolved through this pull request. Additionally, I suggest removing the CC (cryptoconditions) workflows from the CI, as CC is considered to be EOL (end-of-life). However, this change will require an additional pull request.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please provide a comment on the purpose and usage of this script

@DeckerSU DeckerSU merged commit 9d8c5f6 into GLEECBTC:dev Oct 28, 2023
who-biz pushed a commit to who-biz/komodo that referenced this pull request Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants