Conversation
to pass two params in a function earlier we used a (void **) to handle pointers on these 2 params in "array". also there was "hidden" parameter, this pointer itself, if pointer == 0 -> it before HF time, if pointer !=0 -> after HF time, and we should extract two params from array of passed pointers. of course it can be replaced with tuple, or boost::optional with tuple "inside", but much more simple way is to pass params (CScript and nLockTime) in komodo_notaryvin same way as they exits and assume that if passed CScript().size() == 0, it before HF and if size() > 0 - it after HF. # Conflicts: # src/miner.cpp
"Backport" of bitcoin/bitcoin#10534 to our codebase. TODO: consider to use latest prevector implementation from Bitcoin upstream.
This reverts commit 2a54247.
HF22 (HFNET) Consensus Changes
s6 mainnet pubkeys and timestamps
bump version (0.7.2), KOMODO_VERSION (0.7.2) and copyright year
sync beta [0.7.2]
Collaborator
|
I went over the code in this PR and did not find any issues (apart from that small issue with libcc mentioned above). |
DeckerSU
approved these changes
Jun 12, 2022
Alrighttt
reviewed
Jun 12, 2022
| similar functions: | ||
| - isminetype CWallet::IsMine(const CTransaction& tx, uint32_t voutNum) (wallet.cpp) | ||
| - isminetype IsMineInner(const CKeyStore& keystore, const CScript& _scriptPubKey, IsMineSigVersion sigversion) (wallet_ismine.cpp) | ||
| TODO: sort this out (!) |
Closed
Alrighttt
approved these changes
Jun 13, 2022
tonymorony
approved these changes
Jun 13, 2022
who-biz
pushed a commit
to who-biz/komodo
that referenced
this pull request
Jul 29, 2024
Release v1.1.1-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Komodo 0.7.2 [Longpan]