fix init of event_notarized dest field#498
Merged
ca333 merged 1 commit intoGLEECBTC:devfrom Sep 23, 2021
Merged
Conversation
dimxy
approved these changes
Sep 23, 2021
ca333
approved these changes
Sep 23, 2021
|
will merge and propagate to master for NN update re-announcement. @jmjatlanta plz do retrospective review regardless of merge :) |
|
This PR fixes the printouts that we experienced in Notary Nodes. I've just tested it. |
who-biz
pushed a commit
to who-biz/komodo
that referenced
this pull request
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
[COIN] verifynotarization error unexpected dest.(...)error.@jmjatlanta @dimxy @ca333 plz, review it.
p.s. As we forgot to init
destfield in two places, i made it part of ctor's to prevent such mistakes in future.