Merged
Conversation
Since we added mini-gmp.c as a part of libbitcoin_server_a_SOURCES, -fPIC is required to avoid the linkage error: /usr/bin/ld: libbitcoin_server.a(libbitcoin_server_a-mini-gmp.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC libbitcoin_server.a: error adding symbols: Bad value collect2: error: ld returned 1 exit status TODO: In future we should totally (!) get rid of mini-gmp.c, for example, same way as i did here - bf14e82 , bcz actually we using only two functions from this mini-gmp.c - it's bitcoin_base58decode and bitcoin_base58encode, which are perfectly could be replaced with C++ analogs DecodeBase58, EncodeBase58 from base58.h
ca333
approved these changes
Sep 19, 2021
who-biz
pushed a commit
to who-biz/komodo
that referenced
this pull request
Mar 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without these changes you will catch several linkage errors, like:
More detailed information:
DeckerSU@d99e7d2