Skip to content

adds fetch-params script that still uses zcash url#458

Merged
ca333 merged 5 commits intoGLEECBTC:devfrom
gcharang:dev
Jun 13, 2021
Merged

adds fetch-params script that still uses zcash url#458
ca333 merged 5 commits intoGLEECBTC:devfrom
gcharang:dev

Conversation

@gcharang
Copy link
Copy Markdown

No description provided.

@DeckerSU
Copy link
Copy Markdown

DeckerSU commented Jun 13, 2021

About #458 we should agree - will we use self-hosted as it already merged in #450 or continue to use ZCash.

If self-hosted - this PR should be closed. If continue to use ZCash - #450 should be reverted, and #458 should add needed changes in fetch-params.bat also.

p.s. Personally me vote for self-hosted variant.

@DeckerSU DeckerSU mentioned this pull request Jun 13, 2021
@gcharang
Copy link
Copy Markdown
Author

Our self hosted version is on a VPS right now and may not be able to serve many concurrent downloads. Adding this script till we setup a CDN for these files

@DeckerSU
Copy link
Copy Markdown

DeckerSU commented Jun 13, 2021

Our self hosted version is on a VPS right now and may not be able to serve many concurrent downloads. Adding this script till we setup a CDN for these files

Then we need changes in fetch-params.bat also:

fetch-params.bat.patch

diff --git a/zcutil/fetch-params.bat b/zcutil/fetch-params.bat
index f9e70d481..0b542d28c 100644
--- a/zcutil/fetch-params.bat
+++ b/zcutil/fetch-params.bat
@@ -6,7 +6,7 @@ MKDIR "%APPDATA%"\ZcashParams
 )
 IF NOT EXIST "%APPDATA%"\ZcashParams\sprout-proving.key (
     ECHO Downloading Zcash trusted setup sprout-proving.key, this may take a while ...
-    .\wget64.exe --progress=dot:giga --continue --retry-connrefused --waitretry=3 --timeout=30 https://z.cash/downloads/sprout-proving.key -O "%APPDATA%"\ZcashParams\sprout-proving.key
+    .\wget64.exe --progress=dot:giga --continue --retry-connrefused --waitretry=3 --timeout=30 https://z.cash/downloads/sprout-proving.key.deprecated-sworn-elves -O "%APPDATA%"\ZcashParams\sprout-proving.key
 )
 IF NOT EXIST "%APPDATA%"\ZcashParams\sprout-verifying.key (
     ECHO Downloading Zcash trusted setup sprout-verifying.key, this may take a while ...

And:
VerusCoin.xml.patch

diff --git a/zcutil/VerusCoin.xml b/zcutil/VerusCoin.xml
index 914e2f14b..7e4b39d94 100644
--- a/zcutil/VerusCoin.xml
+++ b/zcutil/VerusCoin.xml
@@ -252,7 +252,7 @@
                     <filename>${windows_folder_appdata}/ZcashParams/sprout-proving.key</filename>
                     <progressText>Zcash Params file: sprout-proving.key</progressText>
                     <showMessageOnError>0</showMessageOnError>
-                    <url>https://z.cash/downloads/sprout-proving.key</url>
+                    <url>https://z.cash/downloads/sprout-proving.key.deprecated-sworn-elves</url>
                 </httpGet>
             </actionList>
             <ruleList>

Please, add the changes above in this PR as well.

@gcharang
Copy link
Copy Markdown
Author

add the changes above in this PR as well

done

@gcharang gcharang marked this pull request as draft June 13, 2021 09:22
@gcharang
Copy link
Copy Markdown
Author

gcharang commented Jun 13, 2021

@DeckerSU are the patches you shared enough or should I also change the rest of the komodoplatform.com strings to z.cash strings in both the ./zcutil/VerusCoin.xml and ./zcutil/fetch-params.bat files?

@DeckerSU
Copy link
Copy Markdown

@DeckerSU are the patches you shared enough or should I also change the rest of the komodoplatform.com strings to z.cash strings in both the ./zcutil/VerusCoin.xml and ./zcutil/fetch-params.bat files?

Depends on what we will do with #457 and #450 , wait for #457 merged and depends on will #450 in #457 will be reverted or not -> update #458.

@gcharang
Copy link
Copy Markdown
Author

gcharang commented Jun 13, 2021

@DeckerSU @ca333 please review

I removed the fetch-params-zcash.sh file and updated the contents of fetch-params.sh to use the https://z.cash/downloads/sprout-proving.key.deprecated-sworn-elves file

for now all the fetch scripts(including windows ones) use the https://z.cash/downloads/sprout-proving.key.deprecated-sworn-elves file and the usual z.cash urls for the rest

only the fetch-params-alt.sh script uses the selfhosted versions

we can switch all the scripts to self hosted once we have CDN ready for these files

@gcharang gcharang marked this pull request as ready for review June 13, 2021 10:10
@ca333
Copy link
Copy Markdown

ca333 commented Jun 13, 2021

@DeckerSU @ca333 please review

I removed the fetch-params-zcash.sh file and updated the contents of fetch-params.sh to use the https://z.cash/downloads/sprout-proving.key.deprecated-sworn-elves file

for now all the fetch scripts(including windows ones) use the https://z.cash/downloads/sprout-proving.key.deprecated-sworn-elves file and the usual z.cash urls for the rest

only the fetch-params-alt.sh script uses the selfhosted versions

we can switch all the scripts to self hosted once we have CDN ready for these files

sounds good. maybe we should add the corresponding fetch-params-alt.bat ?

Discussing further enhancements - e.g. sprout should not be used anymore, really - thus sprout params requirement removal will come sooner than later.

@gcharang
Copy link
Copy Markdown
Author

@ca333 pushed alt script for win

@GLEECBTC GLEECBTC deleted a comment from gcharang Jun 13, 2021
@ca333 ca333 merged commit e27c6f9 into GLEECBTC:dev Jun 13, 2021
who-biz pushed a commit to who-biz/komodo that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants