ExtractDestination is disabled to have vsolutions size > 1#429
ExtractDestination is disabled to have vsolutions size > 1#429ca333 merged 4 commits intoGLEECBTC:devfrom
Conversation
…21 HF to prevent index breaking
|
|
||
| bool komodo_Is2021JuneHFActive() | ||
| { | ||
| return GetLatestTimestamp(komodo_currentheight()) > nS5Timestamp; |
There was a problem hiding this comment.
any specific reason why we use timestamp as opposed to block height check? As you know for Komodo blockchain it is komodo hardfork-height != hardfork-timestamp and difference can be significant
There was a problem hiding this comment.
I guess timestamp check only is used bcz this change is related to CC, and CC are active only in smartchains for now. But may be will be better to define komodo_Is2021JuneHFActive as:
bool komodo_Is2021JuneHFActive(uint32_t time)
{
return ( (ASSETCHAINS_SYMBOL[0] == 0 && chainActive.Height() > nS5HardforkHeight) || (ASSETCHAINS_SYMBOL[0] != 0 && time > nS5Timestamp) );
}
There was a problem hiding this comment.
this fix is supposed for cc chains (maybe it is better to rename the komodo_Is2021JuneHFActive() function to clarify it is timestamp based)
There was a problem hiding this comment.
this function was designed as self-contained, with no params, as it is called only one-time to fix one specific potential issue in standard.cpp (where we do not have neither chain time nor height)
There was a problem hiding this comment.
i see. just offered a universal function, that can be used in other places too if needed. bcz currently we haven't any other function to determine is the S5 hardfork active or not.
There was a problem hiding this comment.
the code is not active on any chains other than ac_cc, so it's safe to do only the timestamp activation IMO
|
I am having build problems on linux with this PR - do not merge!! |
added the func's stubs to allow utils to build
|
updated the PR, added a time-activation function stub in the utils to allow the utils to build |
(c) GLEECBTC/komodo-daemon#429 TODO: consider possibility of remove any conditions based on timestamp in standart.cpp after S5 hardfork, leaving only "after hardfork" branch. Need to check all CC enabled chains sync from scratch to have clear is removing conditions safe or not.
disable vSolutions size > 1 after June2021 HF as it might break addressindex (this was mistakenly pulled from verus code)