Conversation
|
Looks good. I will coordinate a hard fork testnet in the coming week using this code. |
| const int32_t nS4HardforkHeight = 1922000; //dPoW Season 4 2020 hardfork Sunday, June 14th, 2020 | ||
|
|
||
| const uint32_t nS5Timestamp = 1623682800; //dPoW Season 5 Monday, June 14th, 2021 (03:00:00 PM UTC) | ||
| const int32_t nS5HardforkHeight = 2437300; //dPoW Season 5 Monday, June 14th, 2021 |
There was a problem hiding this comment.
2437300 - 2384484 = 52816
52816/1440 = ~36.6 days from now
Probably ok, but likely to happen earlier than the comment states
There was a problem hiding this comment.
Using height_in_future = last_block_number + ((future_time - time_now) / block_time)
2384540 + ((1623682800 - 1620522112)/60) = 2437218.133333333
Can update just before merge to get closer value if needed, seems this will shift depending on block production rate in the interval.
There was a problem hiding this comment.
2437300 - 2384484 = 52816
52816/1440 = ~36.6 days from nowProbably ok, but likely to happen earlier than the comment states
There was a problem hiding this comment.
LGTM, but seems we forgot to change NUM_KMD_SEASONS constant here:
https://github.com/KomodoPlatform/komodo/blob/fee6209f729c4b3730d348be99346dfeb0d0ca7c/src/komodo_defs.h#L49
Should be 6.
fix num seasons
No description provided.