Skip to content

Fixes for GitHub CI (MacOS mainly)#420

Merged
ca333 merged 4 commits intoGLEECBTC:researchfrom
jmjatlanta:jmj_ci_fixes
May 9, 2021
Merged

Fixes for GitHub CI (MacOS mainly)#420
ca333 merged 4 commits intoGLEECBTC:researchfrom
jmjatlanta:jmj_ci_fixes

Conversation

@jmjatlanta
Copy link
Copy Markdown

@jmjatlanta jmjatlanta commented May 4, 2021

  • .yml files attempted apt-get remove of various PHP versions, which all fail. Removed PHP packages from apt-get remove.
  • mac builds failed due to check in the gmp lib, removed check.
  • dirent.h uses __unused. Added -Wno-error:attributes to CXXFLAGS on mac
  • mac C headers use c++ style comments. Removed forcing compiler to c89 standard.

Outstanding questions:

  • What is the purpose of the de-installation of PHP? Are such removals required?
  • What is a good test of libgmp that can be used on all platforms supported?
  • What version of the C compiler should we support? 2011? 2017?

@TheComputerGenie
Copy link
Copy Markdown

TheComputerGenie commented May 4, 2021

What is the purpose of the de-installation of PHP? Are such removals required?

Gh Actions were borked for a while last year and it was a required "patch" to keep it working and just never removed after

@ca333 ca333 requested review from Alrighttt, DeckerSU and tonymorony May 6, 2021 08:57
@tonymorony
Copy link
Copy Markdown

tonymorony commented May 7, 2021

What is the purpose of the de-installation of PHP? Are such removals required? yeah, apt-get update failed without this removal because of broken azure apt repos

@SirSevenG - could you please have a look on ChannelsCC test? it looks like only this one is failing atm, would be great to fix

@SirSevenG
Copy link
Copy Markdown

SirSevenG commented May 7, 2021 •
edited
Loading

@jmjatlanta PRed to your repo a few updates to .yml files. jmjatlanta#3

@tonymorony Will add test updates in separate PR.

We would probably want same .yml updates in dev branch.

What is the purpose of the de-installation of PHP? Are such removals required?

Azure repos GH workers use tend to have issues with said packages. And a few more - all included in my pr.

What is a good test of libgmp that can be used on all platforms supported?

According to configure.ac comments we can sklip libgmp check if we update pckg we use in deps. https://github.com/KomodoPlatform/libgmp
Newer version provides pkgconfig config. (6.2.1)

@ca333 ca333 merged commit 20d8bc5 into GLEECBTC:research May 9, 2021
@ca333 ca333 mentioned this pull request May 9, 2021
Merged
dimxy pushed a commit that referenced this pull request May 25, 2021
picked Merge pull request #420 from jmjatlanta/jmj_ci_fixes
d685aac
who-biz pushed a commit to who-biz/komodo that referenced this pull request Jun 14, 2022
@Asherda
Merge pull request GLEECBTC#420 from VerusCoin/dev
79cde17 
Dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alrighttt Alrighttt Awaiting requested review from Alrighttt

@DeckerSU DeckerSU Awaiting requested review from DeckerSU

1 more reviewer

@tonymorony tonymorony tonymorony approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmjatlanta @TheComputerGenie @tonymorony @SirSevenG @ca333