Skip to content

temp disable NSPV messages processing#378

Merged
ca333 merged 2 commits intoGLEECBTC:disable_nspvfrom
DeckerSU:patch-disablenspv
Jul 27, 2020
Merged

temp disable NSPV messages processing#378
ca333 merged 2 commits intoGLEECBTC:disable_nspvfrom
DeckerSU:patch-disablenspv

Conversation

@DeckerSU
Copy link
Copy Markdown

No description provided.

@ca333 ca333 self-requested a review July 26, 2020 22:41
@ca333 ca333 changed the base branch from dev to disable_nspv July 27, 2020 10:16
@ca333 ca333 merged commit ace78db into GLEECBTC:disable_nspv Jul 27, 2020
@dimxy
Copy link
Copy Markdown
Collaborator

dimxy commented Jul 27, 2020

if we adding a nspv protocol enable/disable flag it is also better to turn on/off announce of nspv services by the node accordingly:

void CAddress::Init()
{
    nServices = NODE_NETWORK | NODE_NSPV;
    nTime = 100000000;
}

@DeckerSU DeckerSU mentioned this pull request Jul 27, 2020
@DeckerSU
Copy link
Copy Markdown
Author

I guess here we should make it optional also:
https://github.com/KomodoPlatform/komodo/blob/666047b4f56778927a1787a8743fbb4bbede6068/src/net.cpp#L86
Like:

uint64_t nLocalServices = NODE_NETWORK | (GetBoolArg("-nspv_msg", false) ? NODE_NSPV : 0);

Alrighttt pushed a commit to Alrighttt/komodo that referenced this pull request Oct 7, 2025
Fix typo in preprocessor `#if` condition for `__STDC_VERSION__` check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants