Skip to content

updates the assetchains.old file to add "$1" at the end of all the ch…#375

Merged
ca333 merged 1 commit intoGLEECBTC:devfrom
gcharang:dev
Jul 2, 2020
Merged

updates the assetchains.old file to add "$1" at the end of all the ch…#375
ca333 merged 1 commit intoGLEECBTC:devfrom
gcharang:dev

Conversation

@gcharang
Copy link
Copy Markdown

…ain parameters

@gcharang
Copy link
Copy Markdown
Author

@ca333 @tonymorony please review

@tonymorony
Copy link
Copy Markdown

tonymorony commented Jun 30, 2020

Isn't $1 adding seednode ip as addnode by another script?

as I can see it presists for all ACs without addnode

@gcharang
Copy link
Copy Markdown
Author

we can add or remove them. I just wanted to make them consistent for all chains. I guess it can be used to launch all the chains with -reindex or -rescan

@TheComputerGenie
Copy link
Copy Markdown

...I just wanted to make them consistent for all chains...

You mean like this:
#373 (comment)
?

@gcharang
Copy link
Copy Markdown
Author

gcharang commented Jun 30, 2020

You mean like this

yes, just like that. Full explanation

didn't think the comment was directed at me. I checked the git blame later and it looks like it was my commit that removed those $1 s. it was because I didn't notice the difference when I hastily copy pasted the file from the dpow repo to here

sent a PR to the dPoW repo as well to fix it: KomodoPlatform/dPoW#180

@ca333 ca333 merged commit 9ac57b9 into GLEECBTC:dev Jul 2, 2020
Alrighttt pushed a commit to Alrighttt/komodo that referenced this pull request Oct 7, 2025
Update depends config.guess and config.sub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants