Skip to content

remove WLC#352

Merged
ca333 merged 4 commits intoGLEECBTC:devfrom
smk762:patch-7
May 14, 2020
Merged

remove WLC#352
ca333 merged 4 commits intoGLEECBTC:devfrom
smk762:patch-7

Conversation

@smk762
Copy link
Copy Markdown

@smk762 smk762 commented May 13, 2020

WLC is no longer notarised (was replaced by WLC21)
VRSC might also be candidate for removal, as it is no longer launched as an assetchain

WLC is no longer notarised (was replaced by WLC21)
VRSC might also be candidate for removal, as it is no longer launched as an assetchain
@himu007
Copy link
Copy Markdown

himu007 commented May 13, 2020

These files also worth removing for WLC as they would serve no purpose, otherwise will remain as old.
https://github.com/KomodoPlatform/komodo/blob/dev/src/assetchains.old#L43
https://github.com/KomodoPlatform/komodo/blob/dev/src/ac/wlc
https://github.com/KomodoPlatform/komodo/blob/dev/src/fiat/wlc

https://github.com/KomodoPlatform/dPoW/blob/dev/iguana/coins/wlc_7776
Mention of WLC from this line (though this is not critical but keeping the line clean is better I guess): https://github.com/KomodoPlatform/dPoW/blob/dev/iguana/iguana_notary.c#L547

For VRSC, currently it's needed there as addcoins for dPoW and dpowassets scripts checks the JSON file and takes coins from there in mainnet. If removed, VRSC needs to be added manually dPoW.

@ca333 ca333 merged commit 44233d2 into GLEECBTC:dev May 14, 2020
who-biz pushed a commit to who-biz/komodo that referenced this pull request Jun 22, 2025
Update version and deprecation height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants