rm template matching and pseudo opcodes by ca333 · Pull Request #298 · GLEECBTC/komodo-daemon

ca333 · 2020-03-06T19:03:16Z

Remove dead MSFT dependency

DeckerSU · 2020-03-10T08:55:13Z

./komodo-test have Segmentation fault, when running testInvalidNotarisationBadOpReturn test:

[ RUN      ] TestEvalNotarisation.testInvalidNotarisationBadOpReturn

Program received signal SIGSEGV, Segmentation fault.
0x00005555557c6cf5 in CheckTxAuthority (tx=..., auth=...) at crosschain_authority.cpp:33
33              if (!eval->GetTxUnconfirmed(txIn.prevout.hash, tx, hashBlock)) return false;
(gdb) bt
#0  0x00005555557c6cf5 in CheckTxAuthority (tx=..., auth=...) at crosschain_authority.cpp:33
#1  0x000055555566a9e0 in Eval::CheckNotaryInputs (this=<optimized out>, tx=..., height=<optimized out>, timestamp=<optimized out>) at cc/eval.cpp:179
#2  0x000055555566d317 in Eval::GetNotarisationData (this=this@entry=0x7fffffffcde0, notaryHash=..., data=...) at cc/eval.cpp:190
#3  0x000055555562338d in TestEvalNotarisation::TestEvalNotarisation_testInvalidNotarisationBadOpReturn_Test::TestBody (this=<optimized out>)
    at test-komodo/test_eval_notarisation.cpp:147
#4  0x0000555555669ecf in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) ()
    at /home/decker/ssd_nvme/komodo_malpill/depends/x86_64-unknown-linux-gnu/share/../include/boost/system/detail/std_interoperability.hpp:142
#5  0x0000555555660d20 in testing::Test::Run() ()
    at /home/decker/ssd_nvme/komodo_malpill/depends/x86_64-unknown-linux-gnu/share/../include/boost/system/detail/std_interoperability.hpp:142
#6  0x0000555555660ded in testing::TestInfo::Run() ()
    at /home/decker/ssd_nvme/komodo_malpill/depends/x86_64-unknown-linux-gnu/share/../include/boost/system/detail/std_interoperability.hpp:142
#7  0x0000555555660eeb in testing::TestCase::Run() ()
    at /home/decker/ssd_nvme/komodo_malpill/depends/x86_64-unknown-linux-gnu/share/../include/boost/system/detail/std_interoperability.hpp:142
#8  0x000055555566117a in testing::internal::UnitTestImpl::RunAllTests() ()
    at /home/decker/ssd_nvme/komodo_malpill/depends/x86_64-unknown-linux-gnu/share/../include/boost/system/detail/std_interoperability.hpp:142
#9  0x000055555566a387 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::
internal::UnitTestImpl::*)(), char const*) ()
    at /home/decker/ssd_nvme/komodo_malpill/depends/x86_64-unknown-linux-gnu/share/../include/boost/system/detail/std_interoperability.hpp:142
#10 0x000055555566146c in testing::UnitTest::Run() ()
    at /home/decker/ssd_nvme/komodo_malpill/depends/x86_64-unknown-linux-gnu/share/../include/boost/system/detail/std_interoperability.hpp:142
#11 0x00005555555eec98 in RUN_ALL_TESTS () at /home/decker/ssd_nvme/komodo_malpill/depends/x86_64-unknown-linux-gnu/share/../include/gtest/gtest.h:2233
#12 main (argc=1, argv=0x7fffffffda38) at test-komodo/main.cpp:21

tonymorony · 2020-03-10T08:59:33Z

Btw in case if we starting to work on C code unit-tests base enlarging we can add ./komodo-test tests to Github Action CI/CD.
Please let me know if it neeed @ca333 @DeckerSU

DeckerSU · 2020-03-10T09:32:35Z

Btw ... segfault seems happens here:

https://github.com/KomodoPlatform/komodo/blob/a570d7a69a7af135996f160ee519e696964c0e3c/src/test-komodo/test_eval_notarisation.cpp#L44

When we modify hashBlock, right after return it crashes. If we will comment this line and leave hashBlock untouched here, there is no segfault. But coinimport tests will fail:

[  FAILED  ] 8 tests, listed below:
[  FAILED  ] TestCoinImport.testProcessImportThroughPipeline                                                 
[  FAILED  ] TestCoinImport.testImportTombstone
[  FAILED  ] TestCoinImport.testWrongChainId
[  FAILED  ] TestCoinImport.testPayoutTooHigh
[  FAILED  ] TestCoinImport.testAmountInOpret
[  FAILED  ] TestCoinImport.testInvalidPayouts
[  FAILED  ] TestCoinImport.testCouldntLoadMomom
[  FAILED  ] TestCoinImport.testMomomCheckFail

ca333 · 2020-03-10T10:43:55Z

./komodo-test have Segmentation fault, when running testInvalidNotarisationBadOpReturn

thanks for hinting @DeckerSU - this one was already known and is not related to the updates from #298 - i can work on a fix at a later stage. But would be glad if you find time earlier though.

ca333 · 2020-03-10T10:44:40Z

Btw in case if we starting to work on C code unit-tests base enlarging we can add ./komodo-test tests to Github Action CI/CD.
Please let me know if it neeed @ca333 @DeckerSU

Thanks @tonymorony - yes, lets add that when we fixed komodo-test

DeckerSU · 2020-03-10T12:08:08Z

@ca333 finally, seems i found a root of segfault in komodo-test and fixed it. Apply this patch:

diff --git a/src/test-komodo/test_eval_notarisation.cpp b/src/test-komodo/test_eval_notarisation.cpp
index f0c48f951..2256f4761 100644
--- a/src/test-komodo/test_eval_notarisation.cpp
+++ b/src/test-komodo/test_eval_notarisation.cpp
@@ -130,6 +130,7 @@ TEST(TestEvalNotarisation, testInvalidNotaryPubkey)
 TEST(TestEvalNotarisation, testInvalidNotarisationBadOpReturn)
 {
     EvalMock eval;
+    EVAL_TEST = &eval;
     CMutableTransaction notary(notaryTx);
 
     notary.vout[1].scriptPubKey = CScript() << OP_RETURN << 0;
@@ -143,6 +144,7 @@ TEST(TestEvalNotarisation, testInvalidNotarisationBadOpReturn)
 TEST(TestEvalNotarisation, testInvalidNotarisationTxNotEnoughSigs)
 {
     EvalMock eval;
+    EVAL_TEST = &eval;
     CMutableTransaction notary(notaryTx);
 
     SetupEval(eval, notary, [](CMutableTransaction &tx) {
@@ -157,6 +159,7 @@ TEST(TestEvalNotarisation, testInvalidNotarisationTxNotEnoughSigs)
 TEST(TestEvalNotarisation, testInvalidNotarisationTxDoesntExist)
 {
     EvalMock eval;
+    EVAL_TEST = &eval;
     CMutableTransaction notary(notaryTx);
 
     SetupEval(eval, notary, noop);
@@ -169,6 +172,7 @@ TEST(TestEvalNotarisation, testInvalidNotarisationTxDoesntExist)
 TEST(TestEvalNotarisation, testInvalidNotarisationDupeNotary)
 {
     EvalMock eval;
+    EVAL_TEST = &eval;
     CMutableTransaction notary(notaryTx);
 
     SetupEval(eval, notary, [](CMutableTransaction &tx) {
@@ -183,6 +187,7 @@ TEST(TestEvalNotarisation, testInvalidNotarisationDupeNotary)
 TEST(TestEvalNotarisation, testInvalidNotarisationInputNotCheckSig)
 {
     EvalMock eval;
+    EVAL_TEST = &eval;
     CMutableTransaction notary(notaryTx);
 
     SetupEval(eval, notary, [&](CMutableTransaction &tx) {

as
git apply -v segfault.patch

ca333 · 2020-03-10T13:06:16Z

@ca333 finally, seems i found a root of segfault in komodo-test and fixed it.

excellent - thanks @DeckerSU

Prevents false fails like: https://github.com/KomodoPlatform/komodo/pull/298/checks?check_run_id=497945361

tonymorony

komodo-test doesn't crash on my side anymore, just some tests failing as Decker mentioned above
https://paste.ubuntu.com/p/3gq9mdKvPH/

fix rawtransactions tests amount

DeckerSU · 2020-03-11T23:20:57Z

DeckerSU/KomodoOcean@2957504 - can we also add analog of this commit in current PR. This will prevent of spamming really big hex strings (in case of splitfund tx expired). I guess so detail log was needed for debug purposes, when we had transtition to overwinter / sapling. But now seems it's don't needed anymore.

p.s. Also, i'm working on a fix for a proper removal of "stucked" txes in mempool. We have a case in which tx can be already in mempool on all nodes, but never will included in block - bcz of komodo_validate_interest violation. Seems we have an error in code, which should remove it. I'm very close to solution, but not sure, will I have time to fix this till this PR will be closed or no.

DeckerSU · 2020-03-12T02:12:19Z

Seems i fixed it (need to test). There was a big difference, between how it was:

(ASSETCHAINS_SYMBOL[0] == 0
  && tipindex != 0 && komodo_validate_interest(...) ) < 0

and how it should be:

(ASSETCHAINS_SYMBOL[0] == 0
  && tipindex != 0 && komodo_validate_interest(...) < 0 )

More details here:
DeckerSU/KomodoOcean@1fbf1c4

bitcoin/bitcoin#13194 zcash/zcash@2cb14d7 GLEECBTC/komodo-daemon#298

https://github.com/bitcoin/bitcoin/pull/13002/files GLEECBTC/komodo-daemon#298

Update version and deprecation height

ca333 added 8 commits March 6, 2020 19:25

rm template matching and pseudo opcodes

0fc66eb

add ValidSize()

bc5cb3b

add IsPushOnly(const_iterator)

abf64c1

rm bare multisig outputs

852a65f

rn arg

9f0b20e

rm shadowed param

354cfc8

keep CLTV tx recognizer

6c1a443

def HaveKeys()

91d0a59

ca333 marked this pull request as ready for review March 8, 2020 21:46

tonymorony and others added 2 commits March 9, 2020 16:58

Update komodod_ci.yml

da885b1

Merge pull request #301 from KomodoPlatform/ci_fix

63b2444

Remove dead MSFT dependency

ca333 requested review from DeckerSU and tonymorony March 10, 2020 11:35

ca333 and others added 2 commits March 10, 2020 14:14

fix notarization test segfault

3d853d8

fix rawtransactions tests amount

87ae0ad

Prevents false fails like: https://github.com/KomodoPlatform/komodo/pull/298/checks?check_run_id=497945361

tonymorony previously approved these changes Mar 11, 2020

View reviewed changes

Merge pull request #303 from SirSevenG/patch-1

6947723

fix rawtransactions tests amount

ca333 dismissed tonymorony’s stale review via 6947723 March 11, 2020 13:36

ca333 added 2 commits March 14, 2020 23:18

debug.log spam prevention

40e88a6

disable THROW_IF_SYNCING

2dbb316

ca333 requested a review from tonymorony March 14, 2020 22:47

ca333 merged commit 2cbf4d2 into dev Mar 16, 2020

DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Mar 17, 2020

Remove template matching and pseudo opcodes

337442e

bitcoin/bitcoin#13194 zcash/zcash@2cb14d7 GLEECBTC/komodo-daemon#298

DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Mar 17, 2020

Do not treat bare multisig outputs as IsMine unless watched

22817d3

https://github.com/bitcoin/bitcoin/pull/13002/files GLEECBTC/komodo-daemon#298

who-biz pushed a commit to who-biz/komodo that referenced this pull request Jul 29, 2024

Merge pull request GLEECBTC#298 from Asherda/update-version

9be1bf5

Update version and deprecation height

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rm template matching and pseudo opcodes#298

rm template matching and pseudo opcodes#298
ca333 merged 15 commits intodevfrom
malpill

ca333 commented Mar 6, 2020 •

edited

Loading

Uh oh!

DeckerSU commented Mar 10, 2020

Uh oh!

tonymorony commented Mar 10, 2020

Uh oh!

DeckerSU commented Mar 10, 2020 •

edited

Loading

Uh oh!

ca333 commented Mar 10, 2020

Uh oh!

ca333 commented Mar 10, 2020

Uh oh!

DeckerSU commented Mar 10, 2020

Uh oh!

ca333 commented Mar 10, 2020

Uh oh!

tonymorony left a comment

Uh oh!

DeckerSU commented Mar 11, 2020 •

edited

Loading

Uh oh!

DeckerSU commented Mar 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ca333 commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DeckerSU commented Mar 10, 2020

Uh oh!

tonymorony commented Mar 10, 2020

Uh oh!

DeckerSU commented Mar 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ca333 commented Mar 10, 2020

Uh oh!

ca333 commented Mar 10, 2020

Uh oh!

DeckerSU commented Mar 10, 2020

Uh oh!

ca333 commented Mar 10, 2020

Uh oh!

tonymorony left a comment

Choose a reason for hiding this comment

Uh oh!

DeckerSU commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DeckerSU commented Mar 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ca333 commented Mar 6, 2020 •

edited

Loading

DeckerSU commented Mar 10, 2020 •

edited

Loading

DeckerSU commented Mar 11, 2020 •

edited

Loading