Skip to content

style(docs): Prettier formatting#54

Merged
sumeshir26 merged 9 commits intoFutura-Py:cleanupfrom
im-coder-lg:cleanup
Jan 18, 2022
Merged

style(docs): Prettier formatting#54
sumeshir26 merged 9 commits intoFutura-Py:cleanupfrom
im-coder-lg:cleanup

Conversation

@im-coder-lg
Copy link
Copy Markdown
Member

@im-coder-lg im-coder-lg commented Jan 17, 2022

The same thing happened again. Hopefully the same doesn't happen locally.

@im-coder-lg
style(docs): Prettier formatting
73d68d4 
I want this on the official repo branch.
@im-coder-lg im-coder-lg changed the base branch from master to cleanup January 17, 2022 07:39
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 17, 2022 •
edited
Loading

✔️ Deploy Preview for timerx-app ready!

🔨 Explore the source changes: 73d68d4

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61e51cfe2b6bcd0007058858

😎 Browse the preview: https://deploy-preview-54--timerx-app.netlify.app

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 17, 2022

From now, no one uses Gitpod except for tests. It's too hard to push. Github's APIs need to fix themselves.

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 17, 2022

Why does ubuntu build fail? (i have art class rn so i cant talk)

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 17, 2022

and why is the windows build not starting? Nothing works!

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 17, 2022

I think it's due to the new tests. Fixing,

@im-coder-lg
Test this on docs
007ccc0 
I broke conventional rules, for now.
@im-coder-lg
Modify readme to apply to new changes.
6de944c 
If this fails, we will revert.
@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 18, 2022

@TimerX-App/reviewers time for review

@sumeshir26 sumeshir26 requested review from a team, not-nef and sumeshir26 and removed request for a team January 18, 2022 04:14
@sumeshir26
Copy link
Copy Markdown
Member

sumeshir26 commented Jan 18, 2022

I think the readme should be kept in the root dir

@sumeshir26 sumeshir26 added documentation Improvements or additions to documentation ready Ready for merge. labels Jan 18, 2022
@sumeshir26
Copy link
Copy Markdown
Member

sumeshir26 commented Jan 18, 2022 •
edited
Loading

@im-coder-lg 28K Aditions and 8K Deletions??!!

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 18, 2022

Prettier. I just did npx prettier --write . from the docs root, never expected that lol.

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 18, 2022

Why did you delete the README from the docs? GitHub accepted it!

@im-coder-lg im-coder-lg self-assigned this Jan 18, 2022
@sumeshir26
Copy link
Copy Markdown
Member

sumeshir26 commented Jan 18, 2022

I reallay think we should keep it in root

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 18, 2022

I reallay think we should keep it in root

Okay, what about contributing.md and code of conduct?

@sumeshir26
Copy link
Copy Markdown
Member

sumeshir26 commented Jan 18, 2022

FYI
image

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 18, 2022

I hate the package lockfile.

@sumeshir26
Copy link
Copy Markdown
Member

sumeshir26 commented Jan 18, 2022

Okay, what about contributing.md and code of conduct?

Those can be kept in the docs folder

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 18, 2022

Okay, but we can't remove the lockfile, npm recommends we commit it.

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 18, 2022

Maybe that's why I hesitated in choosing Prettier. Should have just done npx prettier --write docs/ and the same to src if you consider the root of documentation docs as root.

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 18, 2022

I reallay think we should keep it in root

Why?

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 18, 2022

IDK, maybe it's easy to edit?

@sumeshir26
Copy link
Copy Markdown
Member

sumeshir26 commented Jan 18, 2022

@im-coder-lg Removing the Lockfile and Merging since the lockfile is not really necessary...

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 18, 2022

Alright, fixed merge conflicts. Ready to merge.

@sumeshir26 sumeshir26 merged commit 617d34c into Futura-Py:cleanup Jan 18, 2022
sumeshir26 added a commit that referenced this pull request Jan 18, 2022
@sumeshir26 @im-coder-lg
chore: Repository Cleanup (#57)
9ed9885 
* chore: Delete Scripts Directory

* style: Black formatting (#53)

* Update .gitignore

* Delete .vscode directory

* style(docs): Prettier formatting (#54)

* Fix screenshot relative path

* I think the license is supposed to be in the root.

Co-authored-by: LG <76845820+im-coder-lg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sumeshir26 sumeshir26 Awaiting requested review from sumeshir26 sumeshir26 was automatically assigned from Futura-Py/reviewers

@not-nef not-nef Awaiting requested review from not-nef not-nef was automatically assigned from Futura-Py/reviewers

Assignees

@im-coder-lg im-coder-lg

Labels

documentation Improvements or additions to documentation ready Ready for merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@im-coder-lg @not-nef @sumeshir26