Readme Overhaul#39
Conversation
|
Excellent! |
|
I say this is ready for review! |
|
Also, before the word |
|
@not-nef @im-coder-lg I still think there should be a banner to inform users about new releases. |
|
Yeah even me... Why not the banner be on the website? I mean, that's where users would head for documentation, a gist of features, and etc. |
im-coder-lg
left a comment
There was a problem hiding this comment.
SVG sizing and maybe text modification. What's your idea?
|
@not-nef Maybe we can add more badges through this: https://github.com/Ileriayo/markdown-badges |
|
Maybe these badges: 



These are the ones that seem related for us; any ideas? |
|
We could make the SVGs into links, so I could try linking them like a suggestion. |
|
This one as well: |
|
I thought of it, well let's add them! |
|
ok |
|
it looks terrible @im-coder-lg. i wouldnt use those and just leave the release bade there. But you guys say what to do. |
|
@not-nef Let me try to make a custom release badge |
|
Wait are you designing a SVG? |
|
@not-nef that's what we need.
Hold up! You are using HTML! Just use a |
|
@im-coder-lg Yours is a much better idea |
|
@not-nef seems to be confused. I think 50px is a better idea. I will give the code here, all you need to do is replace and commit. <img src="https://img.shields.io/github/release/sumeshir26/TimerX.svg?style=flat-square" alt="Releases" />To: <img src="https://img.shields.io/github/release/sumeshir26/TimerX.svg?style=flat-square" alt="Releases" width="50px" /> |
|
✔️ Deploy Preview for timerx-app canceled. 🔨 Explore the source changes: 3ad1eb1 🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61d98efdd3324300074f7c41 |
|
@im-coder-lg @sumeshir26 what do you guys think of the new Contributing file? |
|
Never noticed it... I will inspect it to fix grammatical issues. Also #41 needs urgent merging! |
|
I will manage the Contributing guide. Do I need write access to edit since it's on your fork? |
|
The contributing guide is kinda messed up. It's haywire, like my method. But don't you worry. I will fix things up. I was waiting to make this, you did! I will make the same file over at the website too! |
|
cool |
|
Updated the contributing guide. Made sure the base was yours, I added some extras. Maybe I'll make it easy for new people to contribute here. |
A URL redirects, so a `.` might make it hard. Great work @not-nef though, you made the refactor and styling.
|
Now, I can approve. |
im-coder-lg
left a comment
There was a problem hiding this comment.
lasgtm(looks and seems good to me)
|
@sumeshir26 your opinions needed! PS: Some new PRs opened, please inspect) |
|
@im-coder-lg i think we should get rid of the todo list since i dont think it belongs in the readme. if we keep it i think we should put it in another document. |
|
Should I merge? |

What do you think? Suggestions are welcomed and wanted!