Skip to content

feat(docs, netlify): Netlify Configuration#41

Merged
im-coder-lg merged 2 commits intomasterfrom
netlify-toml
Jan 8, 2022
Merged

feat(docs, netlify): Netlify Configuration#41
im-coder-lg merged 2 commits intomasterfrom
netlify-toml

Conversation

@im-coder-lg
Copy link
Copy Markdown
Member

@im-coder-lg im-coder-lg commented Jan 8, 2022

Simple for now, but it might get extensive later on.

Will help us configure builds.
Netlify config, urgent merge. Ready.
Created a Netlify tag too, since we'll have two kinds of errors on deployment:

  1. Docusaurus
  2. Netlify(most likely since Docusaurus is customised to stop most errors).
    Urgent merge+Netlify deploy needed.

@im-coder-lg
feat(docs,-netlify): Netlify Configuration
d0107e0 
Simple for now, but it _might_ get extensive later on.

Will help us configure builds.
@im-coder-lg im-coder-lg added enhancement New feature or request ready Ready for merge. netlify Related to Netlify labels Jan 8, 2022
@im-coder-lg im-coder-lg self-assigned this Jan 8, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 8, 2022 •
edited
Loading

✔️ Deploy Preview for timerx-app ready!

🔨 Explore the source changes: 8c66ade

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61d95d276fd1bc0008972990

😎 Browse the preview: https://deploy-preview-41--timerx-app.netlify.app

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 8, 2022

Netlify will fail. Unless we configure it.

@im-coder-lg
fix(netlify): Publish directory in Netlify TOML
8c66ade 
Just realized, publish dir is relative to basedir.
@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 8, 2022

yo, @sumeshir26 I sent a request to you to join as a reviewer in Netlify. Also @not-nef you too sign up and get a reviewer role. It's free they say.

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 8, 2022 •
edited
Loading

Comment has been resolved by LG

Deploys how I want. What do you think?

Browser metadata 
Path:      /
Browser:   Chrome 96.0.4664.110 on Windows 7
Viewport:  1304 x 665 @1x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Unresolved

@im-coder-lg im-coder-lg mentioned this pull request Jan 8, 2022
Merged
@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 8, 2022 •
edited
Loading

Works!

Browser metadata 
Path:      /
Browser:   Chrome 96.0.4664.110 on Windows 7
Viewport:  1304 x 665 @1x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 8, 2022

That new user is me btw

@im-coder-lg im-coder-lg mentioned this pull request Jan 8, 2022
Closed
@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 8, 2022

Also, I have a frank request. There is a new beta for GitHub Projects that organises everything into tables or boards. With your request, I will start a convenient issue tracker that everyone can see and help on.

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 8, 2022

Oh, just realized - they are only for a global user account. It's gonna make triaging hard for us, especially me since I like a good tabled view.

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 8, 2022

But also - multiple projects can be added with collaborators, meaning we could have a literally convienient issue tracker.

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 8, 2022

I will merge this. It's urgent.

@im-coder-lg im-coder-lg added approved This pull request is ready to merge and removed netlify Related to Netlify labels Jan 8, 2022
@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 8, 2022

Gitpod worked btw

@im-coder-lg im-coder-lg merged commit f4c7d67 into master Jan 8, 2022
@im-coder-lg im-coder-lg deleted the netlify-toml branch January 8, 2022 13:02
@im-coder-lg im-coder-lg added netlify Related to Netlify and removed ready Ready for merge. labels Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sumeshir26 sumeshir26 sumeshir26 approved these changes

@not-nef not-nef Awaiting requested review from not-nef

Assignees

@im-coder-lg im-coder-lg

Labels

approved This pull request is ready to merge enhancement New feature or request netlify Related to Netlify

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@im-coder-lg @sumeshir26