Skip to content

Improved hotkey system#24

Merged
not-nef merged 2 commits intomainfrom
hotkey-improvements
Jul 14, 2022
Merged

Improved hotkey system#24
not-nef merged 2 commits intomainfrom
hotkey-improvements

Conversation

@not-nef
Copy link
Copy Markdown
Member

@not-nef not-nef commented Jul 13, 2022

yay

@Moosems
Copy link
Copy Markdown
Member

Moosems commented Jul 13, 2022

Can I recommend we move completely away from pynput and move to tkinter binds?

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jul 13, 2022

@Moosems that is essentially what this pr is about

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jul 13, 2022

oh wait i gotta remove the imports

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jul 13, 2022

there we go

@Moosems
Copy link
Copy Markdown
Member

Moosems commented Jul 13, 2022

I'll test in a bit and if it works I'll sign off!

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jul 14, 2022

Did you find some time to test it? @Moosems

@Moosems
Copy link
Copy Markdown
Member

Moosems commented Jul 14, 2022

Sadly no, my day turned out to be way busier than I had planned

@not-nef not-nef merged commit b5c17a3 into main Jul 14, 2022
@not-nef not-nef deleted the hotkey-improvements branch July 14, 2022 16:10
not-nef added a commit that referenced this pull request Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customization menu for hotkeys Pynput doesnt release ctrl after hotkey is activated

3 participants