Merged
Conversation
Previously, if a library user passed `CURLOPT_HTTPHEADER` option through `SimplePie::set_curl_options()`, it would discard all headers passed by SimplePie through the `$headers` parameter. Some of those are essential so discarding them is a bad idea. Let’s append the externally provided HTTP headers to the list to be passed to `CURLOPT_HTTPHEADER` instead. There is no simple way to remove the SimplePie-generated headers now but, since it only sets `Accept`, `if-modified-since`, `if-none-match` and `X-FORWARDED-FOR`, it is probably not a big deal. Especially when `FileClient` is about to be deprecated.
Those files should not end up in release packages. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Mar 15, 2025
Alkarex
added a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.