Add option to enable notifications#8458
Merged
Alkarex merged 11 commits intoFreshRSS:edgefrom Jan 29, 2026
Merged
Conversation
Inverted variable name so permission remains fixed Proper name
Alkarex
reviewed
Jan 22, 2026
| FreshRSS_Context::userConf()->show_nav_buttons = Minz_Request::paramBoolean('show_nav_buttons'); | ||
| FreshRSS_Context::userConf()->html5_notif_timeout = max(0, Minz_Request::paramInt('html5_notif_timeout')); | ||
|
|
||
| FreshRSS_Context::userConf()->html5_disable_notif = !Minz_Request::paramBoolean('html5_enable_notif'); |
Member
There was a problem hiding this comment.
I would prefer a positive parameter such as html5_notif_enabled if possible
Contributor
Author
Member
There was a problem hiding this comment.
Even if set to true in config-user.default.php?
Member
|
I have made several fixes. Please test again |
Contributor
Author
|
ok. manually tested it. same behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7330
Changes proposed in this pull request:
clear commit messages
code manually tested
test notification actually happening (how can i trigger it, do i have to wait it), this code fixes permissions.