Skip to content

Add option to enable notifications#8457

Closed
rupakbajgain wants to merge 2 commits intoFreshRSS:edgefrom
rupakbajgain:notification-button
Closed

Add option to enable notifications#8457
rupakbajgain wants to merge 2 commits intoFreshRSS:edgefrom
rupakbajgain:notification-button

Conversation

@rupakbajgain
Copy link
Contributor

@rupakbajgain rupakbajgain commented Jan 22, 2026

Closes #7330

Changes proposed in this pull request:

  • Default behaviour is same
  • Added FreshRSS_Context::userConf()->html5_enable_notif so that, it determines weather user wants notification. (will not show any even it has permission)
  • Added button such that checking it makes it request permission too
image
  • clear commit messages
  • code manually tested

Issue:

  • for new users the default FreshRSS_Context::userConf()->html5_enable_notif starts with true , so default behaviour will be same
  • but old users , this field may be missing in their config,(they will lose notification, need to manually enable it) which may confuse them. is there way to migrate the config file too.

Edit:

  • I inverted variable names html5_enable_notif is now not_html5_enable_notif , so default false on file is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PWA request for notifications

1 participant