SimplePie: Disallow javascript: URI protocol#8263
Draft
Inverle wants to merge 2 commits intoFreshRSS:edgefrom
Draft
SimplePie: Disallow javascript: URI protocol#8263Inverle wants to merge 2 commits intoFreshRSS:edgefrom
javascript: URI protocol#8263Inverle wants to merge 2 commits intoFreshRSS:edgefrom
Conversation
1 task
eba36fc to
cd556b3
Compare
cd556b3 to
574db8a
Compare
Alkarex
reviewed
Nov 29, 2025
Alkarex
reviewed
Nov 29, 2025
|
|
||
| if ($this->disallowed_uri_protocols) { | ||
| foreach ($this->disallowed_uri_protocols as $protocol) { | ||
| $this->strip_uri_protocol($xpath, $protocol); |
Member
There was a problem hiding this comment.
I have not looked into it yet, but I hope there is a better place to call this logic from, instead of having to search via XPath again. Probably in the existing URL processing e.g. for relative URLs, sanitising URLs, HTTPS-enforcing.
Member
There was a problem hiding this comment.
Maybe:
Alkarex
pushed a commit
that referenced
this pull request
Dec 24, 2025
Some [misconfigured instances](#7835) may be stripping out the CSP header that `f.php` sends, which can be mitigated by forcing the browser to download the image instead of displaying it and executing JS code from unsanitized SVGs for example. Contributes to #8263 and #7924 (improving security when CSP is not present)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #7924
See https://portswigger.net/web-security/cross-site-scripting/cheat-sheet#protocols