Conversation
Now, it includes a button to open the current article in a new window and a button to toggle the current article favourite flag. See FreshRSS#7912
|
This looks so nice! Will this PR somehow be availalbe via edge or something? |
|
It will be available in edge only if it is accepted. If you are using git, you can change branch to aledeg:enhance/navbar. |
|
Is this PR already ready for a review?
If no feed article is selected then the new buttons use the first article. It feels a bit strange when I already scrolled down and the first article is out of view (I know, same situation with the navigation buttons at all). At all: While the discussion was around the mobile view, currently the "desktop view" is affected too. It looks strange to have these 2 new buttons there too. |
It depends on how you installed FreshRSS. For instance if using Docker, you can modify your Docker Compose or equivalent like so: freshrss:
image: freshrss/freshrss:7913
build:
context: https://github.com/aledeg/FreshRSS.git#enhance/navbar
dockerfile: Docker/Dockerfile-Alpine
...
If using git, you can just run If using ZIP, you can get https://github.com/aledeg/FreshRSS/archive/refs/heads/enhance/navbar.zip By the way, we should have such instructions in a Q&A or in our documentation somewhere. Help welcome. |
This is more of a POC to see how it is feasible. It can work. I am not saying it should be this way. You were concerned about the difficulty of knowing which article was in focus. This proves that it's already working. If you check the code, most things I've used were existing. |
That doesn't bother me.
But that does. I'm afraid I definitely don't like the worse Fitts' law. :-)
Incidentally, on desktop it also immediately stands out that it's a button and not a proper link. |
It is good to know that it work this way. In my mind I was thinking about the feature "Show articles unfolded by default" |
So good! Thanks for that hint, im not that familiar with Tested your branch:
I definetly think this is an awesome feature! I fully understand your points and appreciate your sense for rather deeply think about features before quickly impelementing them But also:
Having used the PR right now makes me not want to go back |
|
Maybe we can add a action bar on top of the navigation bar with all the actions available in the article footer and header (configurable as them as-well). |
|
Maybe, it can be handle by an extension. |
The new hook allows extension to add their own tool bar to navigate between entries. For instance, if the user wants less or more buttons that what's available by default. See FreshRSS#7912 See FreshRSS#7913
The new hook allows extension to add their own tool bar to navigate between entries. For instance, if the user wants less or more buttons that what's available by default. See FreshRSS#7912 See FreshRSS#7913
The new hook allows extension to add their own tool bar to navigate between entries. For instance, if the user wants less or more buttons that what's available by default. See FreshRSS#7912 See FreshRSS#7913
|
@SHU-red the new hook has been added to the UI. Now, an extension can add something above the navigation buttons. |
|
@SHU-red check the extension I quickly built here https://github.com/aledeg/xExtension-EnhancedNavigation. This way you can rely on the edge branch for the project and use this extention. At the moment, it's limited but I will add some more features and configuration. |
|
@aledeg thank you so much for putting effort into this!
The navbar is there! Awesome! Thank you so so much! |
|
@aledeg my fault: Thank you once more! |
|
Implemented in an extension |
|
@SHU-red I've published the first real version of the extension. I've fixed some errors, add some configuration, change the CSS to smoothly change when you enable/disable a button. If you have time, please check https://github.com/aledeg/xExtension-EnhancedNavigation/releases/tag/0.1.1. Thank you |
HEAD detached at 0.1.1
|
|
You need to configure it |
|
Maybe I should add default values |
|
Do you think you can finish this? |
Now, it includes a button to open the current article in a new window and a button to toggle the current article favourite flag.
See #7912
Closes #7912
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist:
Additional information can be found in the documentation.
The new navbar