Fix favicon hashing in GReader API#7573
Merged
Conversation
This allows the correct iconUrl to be returned from the GReader API for a given feed.
Alkarex
approved these changes
May 9, 2025
Member
|
Thanks! I fixed a few more details. Please double-check. |
Merged
Author
|
I've tested the edge branch with your changes and everything still works. Thank you! |
Alkarex
pushed a commit
that referenced
this pull request
May 9, 2025
Add myself as a contributor for #7573. Co-authored-by: CarelessCaution <189675655+CarelessCaution@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the correct iconUrl to be returned from the GReader API for a given feed.
Closes #7570
Changes proposed in this pull request:
How to test the feature manually:
curl -s -H "Authorization:GoogleLogin auth=apiuser/AUTHKEY" 'HOST/api/greader.php/reader/api/0/subscription/list?output=json'and pick any feed and go to the iconUrl and observe the default icon.Pull request checklist:
[N/A] unit tests written (optional if too hard)
[N/A] documentation updated