Skip to content

Catch extension exceptions in override#7475

Merged
Alkarex merged 3 commits intoFreshRSS:edgefrom
Alkarex:extensions-catch
Apr 1, 2025
Merged

Catch extension exceptions in override#7475
Alkarex merged 3 commits intoFreshRSS:edgefrom
Alkarex:extensions-catch

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Apr 1, 2025

@hkcomori
Copy link
Contributor

hkcomori commented Apr 1, 2025

Thank you. PHPStan no longer gives errors about exceptions.

However, FreshRSS/Extensions#300 expects Minz_ActionException to provide a validation error message to the result page.
This PR returns only HTTP 500 and no error message is served to the result page.
Errors are shown on the log page, but users may have difficulty finding them.

If Minz_ActionException in FreshRSS/Extensions#300 is the wrong usage, what about the idea to provide another exception to serve error message on the web page? (eg. Minz_ValidationException)

@Alkarex
Copy link
Member Author

Alkarex commented Apr 1, 2025

Thanks for the test. Please try again

@Alkarex Alkarex merged commit 3336631 into FreshRSS:edge Apr 1, 2025
1 check passed
@Alkarex Alkarex deleted the extensions-catch branch April 1, 2025 15:55
@hkcomori
Copy link
Contributor

hkcomori commented Apr 2, 2025

Thanks for the change. Makes it easier to find the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants