[ReadingTime] Add options: Reading speed, Source metrics#300
[ReadingTime] Add options: Reading speed, Source metrics#300Alkarex merged 32 commits intoFreshRSS:masterfrom
Conversation
I don't know if it applies here, but they measure typing speed in words per minute (while we do characters per minute), but a word is defined as five characters, making it a more convoluted, misleading version of the same measurement. |
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
|
Not smart, but I ignored the following exception to get through PHPStan.
The |
Because add_load_more_listener() does not called when document.readyState === 'loading' and context was already loaded.
|
Ping @lapineige |
|
Can I leave it to you? |
|
@hkcomori Tests welcome FreshRSS/FreshRSS#7475 |
* Catch extension exceptions in override FreshRSS/Extensions#300 (comment) * Fix error message
|
Thanks for the ping. @hkcomori : if you like, you may add your name in the "author" field or wherever you like in the code to get credit for the additions. I don't mind how. |
…inz_ActionException
Because the log page is more consistent in English.
Because the language setting is for correct character counts, It is not needed for word counts which are space-separated counts.
Because other extensions to FreshRSS/Extensions are not listed there, followed suit.
|
@lapineige Thanks, I added author. |
|
Yes, I think there is nothing else missing. |
|
Why removing the translation ? 🤔 I mean sure not everything is translated, and more languages would be good, but it helps accessing the content for French and non English speakers, and the content is already there 🤔 I can provide the French version of your change:
Results in:
|
@lapineige My fault, I did not realise there was already a part translated
Yes please 👍🏻 |
This reverts commit 0690339.
|
Thanks for the translation. |
fix #292
#292 (comment) suggested a policy of using letters for all languages, but my research shows that reading speed in English is usually measured by word count. So I have provided a choice in the metrics. That is, the original policy of #292.
I'm using the
js_varshook for the first time, is the usage correct?It works fine now, but the
js_varshook is aOneToOnehook, so it might conflict if we use it in another extension too.