Add check for Apache mod_filter to ensure "AddOutputFilterByType" works.#7419
Merged
Alkarex merged 2 commits intoFreshRSS:edgefrom Mar 13, 2025
dezponia:edge
Merged
Add check for Apache mod_filter to ensure "AddOutputFilterByType" works.#7419Alkarex merged 2 commits intoFreshRSS:edgefrom dezponia:edge
Alkarex merged 2 commits intoFreshRSS:edgefrom
dezponia:edge
Conversation
Add check for Apache mod_filter to ensure "AddOutputFilterByType" works.
Member
|
Oh, I forgot to thank you here. And please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md |
Alkarex
pushed a commit
that referenced
this pull request
Apr 28, 2025
Adding myself to CREDITS.md as requested in PR #7419 comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddOutputFilterByTypehas been moved frommod_deflatetomod_filterin Apache 2.3.7. Without themod_filtermodule loaded Apache will error out reading thep/.htaccessfile.Apache documentation about the
AddOutputFilterByTypedirective for reference:https://httpd.apache.org/docs/2.4/mod/mod_filter.html#addoutputfilterbytype
This issue was encountered when installing FreshRSS 1.26.0 in a shared hosting environment where compression is applied at the reverse proxy, not the Apache web server.
Changes proposed in this pull request:
Add check in .htaccess for Apache
mod_filterto ensureAddOutputFilterByTypeworks.It may also be necessary to update the Apache
LoadModuleconfiguration to includemod_filterfor the Docker container files. I haven't tested running this with Docker.How to test the feature manually:
mod_deflate, but withoutmod_filterloaded.AddOutputFilterByTypeAddOutputFilterByTypedirective due to missingmod_filter. If bothmod_filterandmod_deflateare loaded it will also work.Pull request checklist: