Skip to content

Add type#7184

Closed
ColonelMoutarde wants to merge 2 commits intoFreshRSS:edgefrom
ColonelMoutarde:edge
Closed

Add type#7184
ColonelMoutarde wants to merge 2 commits intoFreshRSS:edgefrom
ColonelMoutarde:edge

Conversation

@ColonelMoutarde
Copy link
Contributor

Changes proposed in this pull request:

  • Add type

Pull request checklist:

  • clear commit messages
  • code manually tested

@Alkarex
Copy link
Member

Alkarex commented Jan 6, 2025

I am not found of those random and partial PRs.
At least make the changes for all the same cases. Example to search: function \w+\(\$

@Alkarex Alkarex added this to the 1.26.0 milestone Jan 6, 2025
@Alkarex Alkarex added the php Pull requests that update Php code label Jan 6, 2025
@ColonelMoutarde ColonelMoutarde closed this by deleting the head repository Jan 7, 2025
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Jan 7, 2025
@Alkarex
Copy link
Member

Alkarex commented Jan 7, 2025

I did not mean to close this PR, but to complete it by doing the same fix to all remaining identical situations.
Done in #7191

Alkarex added a commit that referenced this pull request Jan 8, 2025
* Add some missing PHP native types
Replaces #7184

* Clean some types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants