Skip to content

Add a feature to hide articles when they are read#694

Merged
Alkarex merged 1 commit intodevfrom
hide-article
Nov 16, 2014
Merged

Add a feature to hide articles when they are read#694
Alkarex merged 1 commit intodevfrom
hide-article

Conversation

@aledeg
Copy link
Member

@aledeg aledeg commented Nov 2, 2014

This is a new reading option to hide articles when they are read. The hidding process occurs when the article is left for an other article. This way, even when the article is marked as read on opening, it is hidden only while navigating to an other article.
I'm not really happy with the behavior when the "mark while scrolling" option is enabled. Please review.
It is missing the i18n since we're not supposed to push them before it exists on i18n.freshrss.org. Or maybe I misunderstood the process.

See #476

This is a new reading option to hide articles when they are read. The hidding process occurs when the article is left for an other article. This way, even when the article is marked as read on opening, it is hidden only while navigating to an other article.
I'm not really happy with the behavior when the "mark while scrolling" option is enabled. Please review.
It is missing the i18n since we're not supposed to push them before it exists on i18n.freshrss.org. Or maybe I misunderstood the process.

See #476
Alkarex added a commit that referenced this pull request Nov 16, 2014
Add a feature to hide articles when they are read
@Alkarex Alkarex merged commit 2c50ed7 into dev Nov 16, 2014
@Alkarex
Copy link
Member

Alkarex commented Nov 16, 2014

I think you can continue pushing the remaining changes to the same branch

@Alwaysin
Copy link
Contributor

Alwaysin commented Dec 2, 2014

I think the case where an article is marked as read by clicking the red letter at the left of the article (without opening it) has not been taken into account.

@aledeg
Copy link
Member Author

aledeg commented Dec 3, 2014

You're right, I will have a look at that

@aledeg
Copy link
Member Author

aledeg commented Dec 3, 2014

It's fixed. Please check.

@Alwaysin
Copy link
Contributor

Alwaysin commented Dec 3, 2014

Quick and efficient! It's working, thanks :)

@Alwaysin
Copy link
Contributor

Alwaysin commented Dec 3, 2014

Rectification, there is still a little problem but dunno if it is feasible... When an article is opened, and I click on the red letter to mark it as unread, it disappears.

EDIT : it disappears but it looks like the article is nonetheless marked as unread. I see it when I reload the page.

@aledeg
Copy link
Member Author

aledeg commented Dec 3, 2014

I do not understand. What is not working. Please enlighten me.

@Alwaysin
Copy link
Contributor

Alwaysin commented Dec 3, 2014

I have an article opened, and so it is marked as read.
I want to mark it as unread for whatever reason, so I click on the left button. When I do this, the article disappear instead of appearing as an unread article.
But as my edit states, the article appears as it should when refreshing the page.

I did not have a look at the code as I have limited knowledge but I think you did :

  • when clicking on the left button, make the article disappear.

If it is possible I think you should do :

  • when clicking on the left button, AND IF IT IS UNREAD make the article disappear,
  • IF IT IS READ, do not make the article disappear.

I hope I explained it well, just let me know if it is not the case ^^

@aledeg
Copy link
Member Author

aledeg commented Dec 3, 2014

Thank you for the explanation. I understand now.
I will have a look at that tonight.

@aledeg
Copy link
Member Author

aledeg commented Dec 3, 2014

Should be fixed now in 93af0cf

@aledeg
Copy link
Member Author

aledeg commented Dec 4, 2014

There was a bug so I revert it and made a new one 5341088

@Alwaysin
Copy link
Contributor

Alwaysin commented Dec 4, 2014

I confirm it works ! Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants