Merged
Conversation
Member
|
Thanks 👍🏻 I had a bit forgotten about that readme... https://freshrss.github.io/FreshRSS/en/developers/03_Running_tests.html |
Member
|
Will have to be updated to a newer version with our imminent move to PHP 8.1+ #6711 |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Aug 26, 2024
Member
Alkarex
added a commit
that referenced
this pull request
Sep 6, 2024
* Upgrade to PHP 8.1 As discussed in #5474 https://www.php.net/releases/8.0/en.php https://www.php.net/releases/8.1/en.php Upgrade to available native type declarations https://php.net/language.types.declarations Upgrade to https://phpunit.de/announcements/phpunit-10.html which requires PHP 8.1+ (good timing, as version 9 was not maintained anymore) Upgrade `:oldest` Docker dev image to oldest Alpine version supporting PHP 8.1: Alpine 3.16, which includes PHP 8.1.22. * Include 6736 #6736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on Art4#1 I noticed that
wget https://phar.phpunit.de/phpunit.pharwill download the newest version 11 of PHPUnit. With this version one will get a lot of deprecation warnings and errors running the tests.I get the download url from the docs and have tested it successfully.
Changes proposed in this pull request:
How to test the feature manually:
tests/README.mdphp phpunit.phar --versionto see the PHPUnit versionPull request checklist:
Additional information can be found in the documentation.