Fix OIDC session params definition#6730
Merged
Alkarex merged 3 commits intoFreshRSS:edgefrom Aug 25, 2024
Merged
Conversation
- standardize environment variable names - group all in the same configuration file - use mod_auth_openidc default values - fix `OIDCSessionMaxDuration` because it was not set with the previous code - add documentation
Contributor
Author
|
I fixed the sanity checks in bash. |
Alkarex
reviewed
Aug 24, 2024
| OIDCXForwardedHeaders ${OIDC_X_FORWARDED_HEADERS} | ||
| </IfDefine> | ||
|
|
||
| # Can be overridden e.g. in /var/www/FreshRSS/p/i/.htaccess |
Member
There was a problem hiding this comment.
Out of curiosity: isn't it working?
Contributor
Author
There was a problem hiding this comment.
Ouch, nice caught! I don't know what I did sorry. Fixed in 4f697d3
Member
There was a problem hiding this comment.
If you have a chance to test that it actually works, that would be nice. I do not have an OIDC setup at the moment, to experiment
4 tasks
Alkarex
approved these changes
Aug 24, 2024
Alkarex
added a commit
that referenced
this pull request
Aug 26, 2024
+fix minor whitespace from #6730
pando85
added a commit
to pando85/homelab
that referenced
this pull request
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6378
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist:
Additional information can be found in the documentation.