Merged
Conversation
Sole fix needed so far seems to be related to https://wiki.php.net/rfc/deprecate-implicitly-nullable-types See also upstream PR phpgt/CssXPath#227 We are also hitting was seems to be a PHP bug php/php-src#14873
Contributor
|
hi, for help with version upgrades there's rector_php. |
Member
Author
It does not seem to support PHP 8.4, and not even PHP 8.3, does it?
|
Contributor
|
Support for php8.4 will arrive later this year. |
Member
Author
|
This line fails with PHP 8.4.0alpha1 when OPCache is enabled, while the rest seems fine, at a first glance Line 333 in 58c297f |
Merged
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jul 18, 2024
Support https://www.php.net/index.php#2024-07-18-1 Follow-up of FreshRSS#6615 Bug php/php-src#14873 was fixed ndossche/php-src@3d0885f
Alkarex
added a commit
that referenced
this pull request
Jul 18, 2024
Support https://www.php.net/index.php#2024-07-18-1 Follow-up of #6615 Bug php/php-src#14873 was fixed ndossche/php-src@3d0885f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sole fix needed so far seems to be related to https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
See also upstream PR phpgt/CssXPath#227
We are also hitting a PHP bug with
min()function, reported upstream php/php-src#14873