Reading view: action icons position#6297
Conversation
|
LGTM. Thanks for the change! |
|
Tests failing |
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
| <label class="group-name" for="show_article_icons"><?= _t('conf.reading.article.icons') ?></label> | ||
| <div class="group-controls"> | ||
| <select name="show_article_icons" id="show_article_icons" data-leave-validation="<?= FreshRSS_Context::userConf()->show_article_icons ?>"> | ||
| <option value="t" <?= FreshRSS_Context::userConf()->show_article_icons === 't' ? ' selected="selected"' : '' ?> data-input-visible="true"><?= _t('conf.reading.article.icons.above_title') ?></option> |
There was a problem hiding this comment.
Trailing space here - please remember to use https://editorconfig.org in your editor / IDE.
Ref https://github.com/FreshRSS/FreshRSS/pull/6648/files#diff-3b728a20c27f783ad0ba0b0de17c4ca3d681985394672e9a0a5fd2be4d40e567
There was a problem hiding this comment.
should it not caught by the pipeline?
I use VS Code that respects the .editorconfig. But there is no annotation at this place.
Something is here broken I guess
There was a problem hiding this comment.
It's listed right at the start:
Lines 5 to 7 in 0eeac4a
Edit: Maybe it only works if you open the root folder, but not if you open a subfolder or a single document? Although VS Code trims trailing whitespace by default as well.
There was a problem hiding this comment.
In VS Code, make sure you have the corresponding extension https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig
We do not have a CI test for that at the moment (I plan to make an update for PHPCS soon, which might catch it)
There was a problem hiding this comment.
As promised #6666
This will now catch such cases as part of the CI, also also offer automatic fixes with
make test-all
# or isolated:
composer run-script phpcbf
inspired by #6261 from @joshka
(default): above title
in authors and date row
top line article icons configs respected
How to test the feature manually:
reading, sectionArticles: header/footerPull request checklist: