Make reader icon location configurable#6261
Conversation
Putting the Icons for read/unread and bookmark above the header can breaks a user's reading flow. This makes the location of these icons configurable to be placed in one of the following locations: - above the title - in the same line as the header - in the same line as the authors and date
|
Thanks for improving the reading view. Could you please describe what you mean with the users reading flow and how it is connected with these icons? This is the current situation (above title/tags): The icons are on the left side
|
| 'none' => 'None', | ||
| ), | ||
| 'icons' => array( | ||
| '_' => 'Icons', |
There was a problem hiding this comment.
IMHO: Icons is to general. Something like "mark (un)read, favorite buttons" would describe it more precisely
There was a problem hiding this comment.
I agree - I wasn't sure what to put for this. Maybe instead even Article actions. This would allow these to be replaced with text in some future change / (or theme).
There was a problem hiding this comment.
I see Article icons is used in the Display config
There was a problem hiding this comment.
This might be a better UI for the configuration of these things in the reader view too.
| '_' => 'Icons', | ||
| 'above_title' => 'Above title/tags', | ||
| 'with_authors' => 'In authors and date row', | ||
| 'header' => 'In header', |
There was a problem hiding this comment.
In headline or In headline row could be the better description. Maybe a renaming of the key is needed too.
There was a problem hiding this comment.
I copied this one from other settings which put things in the same area.
I'm not 100% sure what the impact of renaming keys would be - I think it's generally good to keep consistent names where possible, and the fact that there's translations for this already is a good argument to use the same terms.
It might be worthwhile to define the areas more specifically however as something like
- above title
- title
- subtitle
- footer
or something like that.
There was a problem hiding this comment.
It is from the dropdown above.
But there it is fine enough to say "header".
In your case all place options are "in the header" ;) It needs to be more specific.
There was a problem hiding this comment.
One downside is that there are translations available for the existing locations mentioned, so changing this to different wording means you lose all the translations. Also, the location options used match the existing locations used in the other options. I figure consistency is key here.
| <option value="a" <?= FreshRSS_Context::userConf()->show_icons === 'a' ? ' selected="selected"' : '' ?> data-input-visible="true"><?= _t('conf.reading.article.icons.with_authors') ?></option> | ||
| <option value="h" <?= FreshRSS_Context::userConf()->show_icons === 'h' ? ' selected="selected"' : '' ?> data-input-visible="true"><?= _t('conf.reading.article.icons.header') ?></option> | ||
| <option value="t" <?= FreshRSS_Context::userConf()->show_icons === 't' ? ' selected="selected"' : '' ?> data-input-visible="true"><?= _t('conf.reading.article.icons.above_title') ?></option> |
There was a problem hiding this comment.
I prefer to use more readable value keys (authors = above, t = title etc.)
There was a problem hiding this comment.
I copied this from the existing settings that use this approach. I also would have preferred these settings to be meaningful, but chose to keep it consistent rather than doing it right.
I'm transitioning off feedly, which looks somewhat like this (oddly appropriate article lol) 
When I'm scanning through a feed, I'm interested often in seeing the headline first for any article as in a Visual UX hierarchy this is the most important thing. I found myself pausing whenever I go to the next article in FreshRSS as there's a big red icon that takes the first visual cue away from the title. 
When thinking about how the hierarchy of elements in a UX, the icons for marking the article read/unread or bookmark have a belongs-to relationship with the article, and hence subjectively belong in the authors and dates line. I felt however this perspective was perhaps too controversial to necessarily be correct for everyone's perspective and noted that the general approach in FreshRSS was to provide options for such things. TL;DR |
|
great to see this example. Now I understand it much better. We are both on the same site, that the reading view needs a better article actions tool bar that is also on the bottom of the article (similar to the normal view). Would it be fine for you if I take some hours/days to think about it? I would create a new PR with a proof of new header/footer layout for the reading view. It could help us for more discussions there. I would appreciate your feedback there. Fine for you? |
Yep - No rush. Ping me with the new PR. I was fixing a personal paper cut. P.S. having the devcontainer made it really easy to contribute a fix. |
|
Closing out in preference to #6297 |
Putting the Icons for read/unread and bookmark above the header can break a user's reading flow.
This makes the location of these icons configurable to be placed in one of the following locations:
Closes #
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist:
there didn't seem to be an obvious place for tests / docs for this.
Additional information can be found in the documentation.