Merged
Conversation
Some recent PRs have broken PHP 7.4 compatibility due to `mixed` typing.
This was referenced Jan 13, 2024
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jan 13, 2024
Follow-up of FreshRSS#6038 Ensure that we do not depend on incompatible libraries like in FreshRSS#6030
Alkarex
added a commit
that referenced
this pull request
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent PR #5662 broke PHP 7.4 compatibility due to
mixedtyping.Also fix detail preventing PHPUnit from running properly for PHP 7.4.