Skip to content

Avoid a warning on non-numeric TRUSTED_PROXY en var#5733

Merged
Alkarex merged 3 commits intoFreshRSS:edgefrom
mossroy:patch-1
Oct 25, 2023
Merged

Avoid a warning on non-numeric TRUSTED_PROXY en var#5733
Alkarex merged 3 commits intoFreshRSS:edgefrom
mossroy:patch-1

Conversation

@mossroy
Copy link
Contributor

@mossroy mossroy commented Oct 24, 2023

Fixes #5732

Changes proposed in this pull request:

  • use a double-bracket syntax, that does not complain when TRUSTED_PROXY env var is not numeric

How to test the feature manually: follow the steps from #5732

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

@Alkarex Alkarex added this to the 1.22.1 milestone Oct 24, 2023
Alkarex
Alkarex reviewed Oct 24, 2023
View reviewed changes
Alkarex
Alkarex requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@Alkarex Alkarex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POSIX

@Alkarex Alkarex added the Docker 🐋 Everything related to Docker label Oct 24, 2023
@mossroy mossroy requested a review from Alkarex October 25, 2023 11:19
@Alkarex Alkarex merged commit 280a1e1 into FreshRSS:edge Oct 25, 2023
@Alkarex
Copy link
Member

Alkarex commented Oct 25, 2023

Thanks! Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

@Alkarex Alkarex mentioned this pull request Oct 25, 2023
Merged
6 tasks
@Alkarex
Copy link
Member

Alkarex commented Oct 28, 2023

If you can, please test freshrss/freshrss:edge, which contains a few additional changes, before we release version 1.22.1.
https://github.com/FreshRSS/FreshRSS/blob/edge/CHANGELOG.md

@mossroy
Copy link
Contributor Author

mossroy commented Oct 28, 2023

I'm currently running it (to be precise, this one: https://hub.docker.com/layers/freshrss/freshrss/edge-arm/images/sha256-c62c0655f28d6e87f0433aeca0ad5fd51e14d3d2e2bf80f4e9360de35ed0909f).
I confirm the 2 issues I created are fixed in this image. And I don't see any visible regression.

@Alkarex
Copy link
Member

Alkarex commented Oct 28, 2023

You mean that it works on ARM for you?

@mossroy
Copy link
Contributor Author

mossroy commented Oct 29, 2023 •
edited
Loading

You mean that it works on ARM for you?

Yes, I've deployed FreshRSS on ARM (armhf and arm64 architectures) since February 2023

@Alkarex
Copy link
Member

Alkarex commented Oct 29, 2023

Sorry, I got confused this PR about proxies with our PRs about OpenID Connect (which is not yet working on ARM)

@Alkarex Alkarex mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alkarex Alkarex Alkarex approved these changes

Assignees

No one assigned

Labels

Docker 🐋 Everything related to Docker Security 🛡️

Projects

None yet

Milestone

1.22.1

Development

Successfully merging this pull request may close these issues.

[BUG] Minor warning in docker logs when setting a non-numeric TRUSTED_PROXY env var

2 participants

@mossroy @Alkarex