-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
Bug (confirmed) 🐞issues that are reproducibleissues that are reproducibleDocker 🐋Everything related to DockerEverything related to DockerSecurity 🛡️
Milestone
Description
Describe the bug
If you set a TRUSTED_PROXY env var with a non-numeric value, like "10.0.0.0/8", there is a warning in the log:
./Docker/entrypoint.sh: 15: [: Illegal number: 10.0.0.0/8
To Reproduce
Steps to reproduce the behavior:
- Deploy freshrss 1.22 through its docker image
- pass a TRUSTED_PROXY env var, with value "10.0.0.0/8"
- Run the container
- See the first line in docker logs:
./Docker/entrypoint.sh: 15: [: Illegal number: 10.0.0.0/8
Expected behavior
There should be no warning, as this is an expected value for this env var, according to the documentation
Environment information (please complete the following information):
- Device: Desktop
- OS: Ubuntu 22.04
- Browser: Firefox 118.0.2
- FreshRSS version: 1.22
- Database version: PostgreSQL 14.7
- PHP version: 8.2.7
- Installation type: docker image 1.22.0-arm (but should be the same with amd)
Additional context
This is because of the following line in entrypoint.sh file:
if [ "$TRUSTED_PROXY" -eq 0 ]; then
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Bug (confirmed) 🐞issues that are reproducibleissues that are reproducibleDocker 🐋Everything related to DockerEverything related to DockerSecurity 🛡️