Chore/processing of depreciations and updating code to php72 minimum#5504
Merged
Alkarex merged 4 commits intoFreshRSS:edgefrom Jul 7, 2023
ColonelMoutarde:chore/processing-of-depreciations-and-updating-code-to-php72-minimum
Merged
Chore/processing of depreciations and updating code to php72 minimum#5504Alkarex merged 4 commits intoFreshRSS:edgefrom ColonelMoutarde:chore/processing-of-depreciations-and-updating-code-to-php72-minimum
Alkarex merged 4 commits intoFreshRSS:edgefrom
ColonelMoutarde:chore/processing-of-depreciations-and-updating-code-to-php72-minimum
Conversation
Alkarex
reviewed
Jul 3, 2023
Alkarex
reviewed
Jul 3, 2023
Alkarex
reviewed
Jul 3, 2023
Alkarex
reviewed
Jul 3, 2023
Alkarex
reviewed
Jul 3, 2023
Alkarex
reviewed
Jul 3, 2023
Alkarex
reviewed
Jul 3, 2023
…ng-code-to-php72-minimum
And revert a few unwanted changes
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jan 13, 2024
Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: FreshRSS#5504 Preparation needed before new PRs of the same type: FreshRSS#5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block.
Alkarex
reviewed
Jan 13, 2024
|
|
||
| /** | ||
| * @throws Minz_ConfigurationNamespaceException | ||
| * @throws JsonException |
Member
There was a problem hiding this comment.
This line (several instances) looks wrong. Fixed in #6037
Alkarex
added a commit
that referenced
this pull request
Jan 15, 2024
Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: #5504 Preparation needed before new PRs of the same type: #5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Pull request checklist: