Phpstan Level6 for View.php#5269
Phpstan Level6 for View.php#5269Alkarex merged 14 commits intoFreshRSS:edgefrom ColonelMoutarde:feature/phpstan-view-file
Conversation
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
|
I have made a few more improvements / fixes c0ec012 |
I add ./app/Models/View.php quickly |
…feature/phpstan-view-file
done |
|
To get some of types right, some more types had to be added to related files. |
I think it's Ok |
Regression from FreshRSS#5269
|
|
||
| <?php if (!empty($items)) { ?> | ||
| <?php $this->logsPaginator->render('logs_pagination.phtml', 'page'); ?> | ||
| <?php $this->logsPaginator->render('logs_pagination.phtml', 0); ?> |
There was a problem hiding this comment.
This was wrong, breaking the pagination. Fixed in #5403
* Fix logs pagination Regression from #5269 * Add better default
* Fix logs pagination Regression from FreshRSS#5269 * Add better default
Native type forgotten from FreshRSS#5269 FreshRSS#5213
| * @param array<string,mixed> $listDAO | ||
| * @return array<int,FreshRSS_Category> | ||
| */ | ||
| private static function daoToCategoryPrepopulated(array $listDAO) { |
Changes proposed in this pull request:
Pull request checklist: