Conversation
#fix FreshRSS#5075 Implementation allowing to take an XML document as input using an XML parser (instead of an HTML parser for HTML+XPath)
|
@mgnsk Would you be able to test this patch? See the new XML+XPath mode: |
Thanks, I'll check it out tomorrow evening. |
Based on FreshRSS#5076 Transforms a JSON document to XML before using the XML+XPath method.
|
Related experimental JSON+XPath functionality: #5079 |
| * Normal XML with XPath scraping | ||
| * @var int | ||
| */ | ||
| const KIND_XML_XPATH = 15; |
There was a problem hiding this comment.
recommandation: use visibilty to constant
There was a problem hiding this comment.
I agree when there is a mix of constants with different visibilities, or potentially the first time we introduce a constant in a class. Otherwise it does not matter as they are public by default, just like classes, and I would rather keep the same syntax than the other surrounding constants.
Yes this works as expected. If the XML contains HTML, it must use a CDATA section just like RSS. |
|
Thanks for the feedback! |
#fix #5075
Implementation allowing to take an XML document as input using an XML parser (instead of an HTML parser for HTML+XPath)