Merged
Conversation
Add missing tzdata in Docker :newest Fallback to UTC if no timezone is defined at all #fix FreshRSS#4906 (comment)
Merged
Member
Author
|
@Alwaysin Please try. This should fix your warning. And then define your |
Contributor
|
I can confirm it suppressed the warning, but the UTC default doesn't seem to have been picked up by the UI: Isn't there a way to detect the timezone from the browser instead of defaulting to UTC? Anyway, I've added my timezone in php.ini and all is good for me now! |
Show fallback timezone everywhere
Member
Author
|
Could you please try again @Alwaysin ? For the things that are server-side rendered, it is not so practical to detect and use browser settings. But not impossible. Anyway, not something for now. |
Contributor
|
All good now! |
cjchung
pushed a commit
to cjchung/FreshRSS
that referenced
this pull request
Jan 20, 2023
* Safer timezone set Add missing tzdata in Docker :newest Fallback to UTC if no timezone is defined at all #fix FreshRSS#4906 (comment) * Better refactoring Show fallback timezone everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#fix User-defined time zone #4906 (comment)