Skip to content

Change new article banner size#4735

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
aledeg:ui/new-article-banner
Oct 15, 2022
Merged

Change new article banner size#4735
Alkarex merged 1 commit intoFreshRSS:edgefrom
aledeg:ui/new-article-banner

Conversation

@aledeg
Copy link
Member

@aledeg aledeg commented Oct 15, 2022

Closes #4686

Changes proposed in this pull request:

  • Change new article banner size on origin-compact theme

How to test the feature manually:

  1. Change theme to origin-compact
  2. Refresh feeds
  3. Validate that the banner is not as chunky as before

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

Only on origin-compact theme

@aledeg aledeg added the UI 🎨 User Interfaces label Oct 15, 2022
@aledeg aledeg added this to the 1.20.1 milestone Oct 15, 2022
@aledeg
Copy link
Member Author

aledeg commented Oct 15, 2022

I've checked every supported theme in edge branch. This is the only theme with the big chunky banner.

Only on origin-compact theme
@aledeg aledeg force-pushed the ui/new-article-banner branch from c5a3e5c to b8a9ff6 Compare October 15, 2022 11:45
@Alkarex Alkarex added Theme 🖌 and removed UI 🎨 User Interfaces labels Oct 15, 2022
@Alkarex Alkarex merged commit e10ff9f into FreshRSS:edge Oct 15, 2022
@aledeg aledeg deleted the ui/new-article-banner branch October 15, 2022 19:08
math-GH pushed a commit to math-GH/FreshRSS that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] New articles banner is chunky

2 participants